Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Slackware #1387

Closed
wants to merge 1 commit into from
Closed

Add Slackware #1387

wants to merge 1 commit into from

Conversation

voegelas
Copy link

This PR adds support for Slackware Linux.

Checklist

  • based on top of latest source code
  • changelog entry included
  • tests pass on Travis CI
  • git history is clean
  • git commit messages are well-written

@voegelas voegelas marked this pull request as ready for review July 30, 2020 07:14
Copy link
Member

@ferki ferki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, @voegelas! I prefer discussing changes in issue before implementing them, sadly this step was skipped this time (and I'll work on the contributing guide to make that more obvious).

Unfortunately I don't use Slackware, nor has access to a machine running it, so I can't test these changes, or commit to long-term maintenance of it myself. It would be good to know if you are interested in maintaining Slackware-related bits of Rex in the future. That being said, at this point in time we can try to onboard all of it into Rex core, with the remark that it might be split out at a later point in time.

With the above out of the way, I see only one bigger missing component missing at first glance, which is is handling package management on Slackware. The last similar issue we worked on was #1258 about adding Void Linux support. Basically the same should be true for Slackware support as well, so you can check that out for reference.

Should there be further major discussion points, please open an issue for this topic, or ask directly on IRC!

@voegelas
Copy link
Author

voegelas commented Aug 2, 2020

I would have been interested in mainting the Slackware-related bits but I don't like your unfriendly response. I will close the this pull request and use Ansible instead.

@voegelas voegelas closed this Aug 2, 2020
@ferki
Copy link
Member

ferki commented Aug 2, 2020

I'm sad to read you found my reply unfriendly. Thanks for the feedback and for closing the PR since you will no longer be needing this. All the best in the future with Ansible!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants