Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enum34 only where it's needed #34

Merged
merged 3 commits into from
Jul 4, 2018
Merged

Conversation

funkyHat
Copy link
Contributor

@funkyHat funkyHat commented Jul 4, 2018

In some configurations installing enum34 into a newer Python can break stdlib packages as it may mask the stdlib enum module

funkyHat added 2 commits July 4, 2018 15:12
In some configurations installing enum34 into a newer Python can break stdlib packages as it may mask the stdlib enum module
@codecov
Copy link

codecov bot commented Jul 4, 2018

Codecov Report

Merging #34 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #34   +/-   ##
=======================================
  Coverage   91.14%   91.14%           
=======================================
  Files          45       45           
  Lines        2609     2609           
  Branches      270      270           
=======================================
  Hits         2378     2378           
  Misses        142      142           
  Partials       89       89

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6647271...e2c44bc. Read the comment docs.

@Revolution1
Copy link
Owner

Thank you for contributing!

The mark works well with pip install -r but seems not works with setup.py -> parse_requirements() https://github.com/Revolution1/etcd3-py/blob/master/setup.py#L31

Could you remove enum34 it from requirements.txt and add it to https://github.com/Revolution1/etcd3-py/blob/master/setup.py#L82 ?

@Revolution1 Revolution1 merged commit 9ee85c9 into Revolution1:master Jul 4, 2018
@Revolution1 Revolution1 mentioned this pull request Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants