Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lazy aiohttp client creation #115

Merged
merged 1 commit into from
Nov 7, 2019
Merged

Conversation

Revolution1
Copy link
Owner

@Revolution1 Revolution1 commented Nov 7, 2019

fix #114

Only happens when aiohttp>=4.0 (currently 4.0.0a1)
Only happens when you init a AioClient before eventloop runs. (run the example in readme)

Very narrow case, not test needed.

No need to release a new version for that.

@codecov
Copy link

codecov bot commented Nov 7, 2019

Codecov Report

Merging #115 into master will decrease coverage by 0.32%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #115      +/-   ##
=========================================
- Coverage   91.42%   91.1%   -0.33%     
=========================================
  Files          52      52              
  Lines        3056    3058       +2     
  Branches      316     316              
=========================================
- Hits         2794    2786       -8     
- Misses        157     162       +5     
- Partials      105     110       +5
Impacted Files Coverage Δ
etcd3/baseclient.py 84.15% <100%> (+0.15%) ⬆️
etcd3/aio_client.py 77.98% <100%> (+0.13%) ⬆️
tests/test_watch_util.py 90.69% <0%> (-4.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9955bc6...7260249. Read the comment docs.

@Revolution1 Revolution1 merged commit fc923c5 into master Nov 7, 2019
@Revolution1 Revolution1 deleted the fix/issue114-aiohttp4-breaking branch November 7, 2019 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the AioClient has an exceptiion with call range() function
1 participant