Fixes Compose<->K2 compilation error #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonidero
reviewed
Jun 25, 2024
...uecatui/src/iosMain/kotlin/com/revenuecat/purchases/kmp/ui/revenuecatui/PaywallOptionsKtx.kt
Show resolved
Hide resolved
tonidero
approved these changes
Jun 26, 2024
1 task
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This was reported by Andy during the bug bash. Trying to compile a call to the
Paywall()gives an error very similar to JetBrains/compose-multiplatform#4809.That's a Compose compiler issue which occurs when using K2 (with Kotlin 2.0.0). Even though the issue is closed, it is still happening as is evident from the comments. (See also Decompose, another Compose Multiplatform library: arkivanov/Decompose#727.)
Solution
The solution in this PR is to downgrade Kotlin to 1.9.23. I also updated Compose Multiplatform to 1.6.11 for good measure.
We needed Kotlin 2.0.0 for the
@ObjCSignatureOverrideannotation, but for now it seems to do fine without it. (🤞) Downgrading Kotlin is actually beneficial for our users, because it lowers the version constraints for their project too.Notes
.podspecfiles were automatically regenerated. I did not make those changes manually..apifiles have changed, but from what I can tell not really. Some spaces and ordering differences, but nothing substantial.