CI: only store the final report file as test result. #4434
+28
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this is not yet working as expected, hence the draft status.
Motivation
Sometimes CircleCI reports failed tests for a successful job. We deduced that this happens because all report files are uploaded as test results, including reports of test runs that were later retried. This causes CircleCI to parse that earlier report and show a failed test, even though the test eventually passed.
Changes introduced
This PR changes the
store_test_resultscommand where applicable, to only pass the final report file. The entiretest_outputdirectory is still uploaded as an artifact, to help with debugging actual failures.