-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow user to set the paywall content max width #4116
Open
MojtabaHs
wants to merge
12
commits into
RevenueCat:main
Choose a base branch
from
MojtabaHs:feat/content-max-width
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MojtabaHs
force-pushed
the
feat/content-max-width
branch
from
October 7, 2024 11:25
582f8b2
to
f442d06
Compare
Rebased on the |
Any Updates here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Sometimes, it's not ideal to use the entire width of the screen for the paywall.
For example, a fullscreen paywall on an iPad looks like this by default:
👆This is a 10-inch iPad, but imagine a 13-inch!
This extremely wide content looks off, doesn't it? Who needs a button that's
2752 px
(or1376 pt
) wide?! 😱 (Specially with these short texts!)✅ Customized with the New API
By limiting it to a more readable size, it looks like this:
👆The width of this paywall is limited to the native Readable Content Guide.
Much better, right?
💡 Usage
👆I used the native
readableContentGuide
as Apple suggested for the device here, but the user can pass any value that suits them.More about this contribution