fix: check update by release version, minor fixes #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jackblk
commented
Dec 3, 2021
jackblk
commented
- use github release api to check for version
- remove unused check-update-github package
- fix uncaught exception when checking for version SyntaxError: Unexpected end of JSON input #152
- update gitignore & dockerignore
- refactor dockerfile & bump apprise version
* use github release api to check for version * remove unused check-update-github package * fix uncaught exception when checking for version Revadike#152 * update gitignore & dockerignore * refactor dockerfile & bump apprise version
Revadike
reviewed
Dec 3, 2021
Revadike
reviewed
Dec 3, 2021
Revadike
reviewed
Dec 3, 2021
Revadike
reviewed
Dec 3, 2021
Revadike
reviewed
Dec 3, 2021
Revadike
requested changes
Dec 3, 2021
|
@Revadike updated the PR. Thanks for the suggestions, I think it looks better now. |
Revadike
approved these changes
Dec 4, 2021
|
I was just thinking, maybe we add an auto-update module instead? That way we can push fixes and people won't even have to manually update it. @jackblk |
|
@Revadike Good idea, for node user they will need to update manually so this will help. However, if they use Docker container then it is already auto update if I push a new version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.