Handle static CURL #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Especially) on Windows we need to define `CURL_STATICLIB` when linking to the static curl library or we get errors such as: > unresolved external symbol __imp__curl_free Check if the CURL target from the CMake config file (of CURL) was used and trust them to set that define. Otherwise apply a heuristic to detect whether static CURL was found and set the define (and libs for MSVC) in that case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Especially) on Windows we need to define
CURL_STATICLIBwhen linking to the static curl library or we get errors such as:Check if the CURL target from the CMake config file (of CURL) was used and trust them to set that define.
Otherwise apply a heuristic to detect whether static CURL was found and set the define (and libs for MSVC) in that case