Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

path and filenames for lua files are case sensitive #1636

Closed
stefson opened this issue Nov 7, 2023 · 2 comments · Fixed by #1637
Closed

path and filenames for lua files are case sensitive #1636

stefson opened this issue Nov 7, 2023 · 2 comments · Fixed by #1637

Comments

@stefson
Copy link
Contributor

stefson commented Nov 7, 2023

both folders have to be created/installed with capital letters only:

/usr/share/s25rttr/RTTR/CAMPAIGNS/roman/
/usr/share/s25rttr/RTTR/CAMPAIGNS/world/

for the indivual campaign files, all these files have to be renamed to .lua instead of .LUA:

MISS200.lua  MISS202.lua  MISS204.lua  MISS206.lua  MISS208.lua  campaign.lua
MISS201.lua  MISS203.lua  MISS205.lua  MISS207.lua  MISS209.lua

likewise for the WORLD folder

@Flamefire
Copy link
Member

Indeed it makes sense to have lowercase here. At least for the lua files,maybe even the folders could be named in lowercase or TitleCase.
@ottml

ottml added a commit to ottml/s25client that referenced this issue Nov 7, 2023
ottml added a commit to ottml/s25client that referenced this issue Nov 7, 2023
ottml added a commit to ottml/s25client that referenced this issue Nov 7, 2023
ottml added a commit to ottml/s25client that referenced this issue Nov 7, 2023
ottml added a commit to ottml/s25client that referenced this issue Nov 7, 2023
ottml added a commit to ottml/s25client that referenced this issue Nov 7, 2023
@ottml
Copy link
Contributor

ottml commented Nov 7, 2023

I changed the extension to lower case lua and renamed the folder to campaigns lower case. Adjusted the path for lua folder in the campaign.lua to lower case. Adjusted global path in files.h to lower case. I am currently testing it on linux and i will potenially extend the test for checking case sensitivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants