-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DuckStation standalone PSX emulator #3486
base: master
Are you sure you want to change the base?
Conversation
mkRomDir "psx" | ||
|
||
# needed? | ||
chown -R $user:$user "$md_inst/bin" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed because -portable
is used ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i removed it and everything seems to still work, so hopefully all ok!?
touch "$config" | ||
chown -R $user:$user "$config" | ||
|
||
# set config defaults |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO the entire config handling should be similar to how we do it in retroarch
: create a default file and copy it when it doesn't exist (i.e. on first installs, otherwise it's added with .rp-dist
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree! I think I've done this now
} | ||
|
||
function build_duckstation() { | ||
cmake -DCMAKE_BUILD_TYPE=Release -DENABLE_DISCORD_PRESENCE=OFF -DUSE_X11=OFF -DUSE_DRMKMS=ON -DBUILD_NOGUI_FRONTEND=ON -DBUILD_QT_FRONTEND=OFF . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the X11
support be enabled for x11
platforms ? (this might need additional dependencies also).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it's needed X11 enabled option platform also will be great option enable option for Desktop QT BUILD frontend will be better for some custom option in the GUI.
And DRMKMS only for only KMS platform .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't have an X11 platform to test but have enabled x11, and drmkms where appropriate
IMHO trying to create an |
|
||
local config="$md_conf_root/psx/duckstation.ini" | ||
|
||
addEmulator 0 "$md_id" "psx" "$md_inst/bin/duckstation-nogui -portable -settings $config -- %ROM%" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here I recommended will add, for the duckstation-qt build on the X11/wayland platforms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have an x11 platform to test but for a RetroPie context i would have thought the controller-driven NOGUI front end would be more appropriate more than a mouse-driven one which I presume QT is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean similar this
addEmulator 1 "$md_id" "psx" "$md_inst/bin/duckstation-nogui -portable -settings $config -- %ROM%"
addEmulator 0 "$md_id" "psx" "$md_inst/bin/duckstation-qt -portable -settings $config -- %ROM%"
https://github.com/stenzek/duckstation/wiki/Command-Line-Arguments
Will needed -fullscreen if you have switch fullscreen Window .
In any case, this would be an alternative option to the no interface and it is the user who chooses which one to use sometimes qt build it's more friendly custom automatic remaps gamepads options than nogui in Desktop Options .
As soon as I have some time I try it on my x86-64 PC or aarch64 platform, which are the devices I have at hand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, yes that makes sense giving the choice, although as I don't have a device to test this is not something I would want to add in this PR, although please feel free to add it yourself later! :)
Many thanks, I test it and it is working very well! |
I've re-tested this with the latest changes, seems to work fine, with a few notices:
|
I don't know if the team is still working on this emulator or not. I use it so far on all my systems and I prefer it to the libretro variant. After the massive updates the emulator has gotten a few days ago, it is not possible to build it anymore. I would be obliged if someone can guide me in finding the solution to the problem. Here is the log :https://pastebin.com/q9sCZVB0. Thanks |
Change the source to
|
SDL nogui seems deprecated and not recommended by author fot latest improvements For Qt build Needed qt6.1 and recommended sdl2 2.0.22 with HIDAPI ON . |
Changing this line: |
Standalone version using the (archived) repo. Draft as there's some issue:
i would still like to generate a default controller setup via an emulationstation script - i started doing this via the evdev backend here: https://github.com/dankcushions/RetroPie-Setup/tree/duckstation-nogui - didn't get very far, but i believe it's possible.