fix(manage): sync dev role attach/detach with legacy permissions value

[wescopeland]

Resolves an issue where attaching/detaching developer roles from the management app does not synchronize that user's legacy Permissions value.

In other words, you can attach a Junior Developer role, but their permissions value won't be automatically updated to 2.

---

After deploy, run:

UPDATE `auth_roles` SET `name` = 'developer-retired' WHERE `name` = 'developer-veteran';

[Jamiras]

I have many reservations about this implementation. If a Moderator applies for Jr. Dev, they'll automatically have their Permissions lowered. Similarly, if they give up being a developer, they'll get reset to Registered.

It probably makes sense to keep these changes, but only apply them for users under Moderator permissions level.

[wescopeland]

It probably makes sense to keep these changes, but only apply them for users under Moderator permissions level.

I believe this should now be done in latest. The role attach/detach is still in place for all users as before, but permissions are not reassigned unless $currentPermissions < Permissions::Moderator.

[Jamiras]

Having this as a secondary gate duplicates the lower logic and creates an opportunity for them to become desync'd. Suggest adding an else return to the logic below:

else
{
    // nothing to synchronize for non-developer roles. we're done
    return;
}

[wescopeland]

Addressed in latest.

[Jamiras]

I think you missed my point. You're still checking the conditions twice.

Instead of:

if (in_array(A, B)) {
    if (A) {
    } elseif (B) {
    }
    do_stuff();
}

just do:

if (A) {
} elseif (B) {
} else {
    return;
}
do_stuff();