fix issue checking fixed size #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks to me like this could cause an issue for messages that have a constant length string array field but all other fields have a fixed size (no other strings or variable length arrays). e.g. |
|
This is related to ros/rosdistro#13614 |
|
I have tested this on my kinetic workstation. It's functional, the build succeeds, and the tests run successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@IanTheEngineer can you test this on kinetic? The
f.typetof.base_typeis the real issue - the other errors would cause things to crash anyway and indicate a bug somewhere else. I'd recommend trying to buildros_corelike in the ticket.