GMLC responseData DialogTimeout

[loayking]

When deploying GMLC with Global Title 0100 with BCDEvenEncodingScheme in the Sccp Address, the last digit of the GT will be truncated, and this will lead to DialogTimeout because the initiated GT has been modified
The solution is configuring Global Title 0100 with BCDOddEncodingScheme in the Sccp Address

[deruelle]

@loayking can you make a pull request with your change as described in our Open Source Playbook ?

[vetss]

Hello @loayking,

thanks, good catch.

But your soulution (https://github.com/RestComm/gmlc/pull/26/files) in also wrong. You can find the proper solution for example in https://github.com/RestComm/smscgateway/blob/master/core/smsc-common-library/src/main/java/org/mobicents/smsc/library/MessageUtil.java see getSccpAddress() method. We have to reuse org.mobicents.protocols.ss7.sccp.parameter.ParameterFactory. This factory selects proper BCDEven/OddEncodingScheme.

[loayking]

Hi Sergery,
Yes you are right , I use it direct to test the concept , but yes we have to reuse org.mobicents.protocols.ss7.sccp.parameter.ParameterFactory to selects the proper BCDEven/OddEncodingScheme.

[deruelle]

hi @loayking, were you able to make progress ?

[loayking]

hi @deruelle still working on it, need little more time to follow vetss way

[vetss]

In the method "SccpAddress convertAddressFieldToSCCPAddress(String address)"
we need to create SccpAddress not buy code:

GlobalTitle0100 gt = new GlobalTitle0100Impl(address, 0, BCDEvenEncodingScheme.INSTANCE,NumberingPlan.ISDN_TELEPHONY, NatureOfAddress.INTERNATIONAL);
return new SccpAddressImpl(RoutingIndicator.ROUTING_BASED_ON_GLOBAL_TITLE, gt, 0,gmlcPropertiesManagement.getHlrSsn());

but by code like:
// 1) this part must be invoked onle in "setSbbContext()" method
ParameterFactory sccpParameterFact = new ParameterFactory();
// 2) this is code for an Sccp address creating:
String address = "....";
NumberingPlan np = NumberingPlan.ISDN_TELEPHONY;
NatureOfAddress na = NatureOfAddress.INTERNATIONAL;
int ssn = gmlcPropertiesManagement.getHlrSsn();
GlobalTitle gt = sccpParameterFact.createGlobalTitle(address, translationType, np, null, na);
return sccpParameterFact.createSccpAddress(RoutingIndicator.ROUTING_BASED_ON_GLOBAL_TITLE, gt, 0, ssn);

[vetss]

Hello @loayking

your update from #27 updates too much code and we can not accept as it is.

I have committed more simple commit:
177b575

Please check if your issue was fixed.

Thanks for bug reporting and provided code.

[loayking]

Hi @vetss
Thanks for your kind feedback,
Your update is just like mine, but what I did is take more possibilities to cover all scenarios regarding GlobalTitleIndicator.
I also considered to update GMLC properties file with GlobalTitleIndicator status if this is approved.
In your commit, if the routing is not base on GT the request will not be sent, but if we make it in configuration, it will be more easy.

BR

[vetss]

Hello @loayking

Firtsly please pay attention that when you are creating your pull request you need to download the last code version (from a master branch) and make your changes as a minimum code change that is needed. Your last pull request contains many format updates and amy be some other changes that are not needed for fixing of this concrete issue. Such "big" update is not possible to be committed because we have a risk to break some logic.

If you need a deeper update (with support of different GTI) fill free to make it as compared with current code (with my last updates). Changes of GMLC properties (GmlcPropertiesManagement) is also possible. This leads also updates fo GmlcPropertiesManagementMBean and updates of CLI and manual part (that should be also provided).

[deruelle]

@vetss shall we add a test case for you commit ?

[vetss]

Hi @deruelle,

such unit test is not a trivial task. I'd like to skip this update unit test if as I understand a fix fit to @loayking demands (please confirm if this, @loayking).

[loayking]

Hi @vetss

actually i did it my way, but yours should do the same.