Make Roman rule internally use Regex rule

[l-x]

Just for consistency... 😄

[henriquemoody]

Since you're doing that, can you extend Regex rule instead? (like Yes rule)

[l-x]

I considered doing so. IMO the Roman Rule is not a special Regexp Rule, it just utilizes the Regexp Rule. Solving this by inheritance would break the OOP design principles.

[henriquemoody]

The Regex rule has no specific method signature, only the same of AbstractRule; and a public variable $regex which, if needed, can be used (and useful) on Roman context as well, think about it:

function validateAndExplain(Regex $regex, $input)
{
    if (!$regex->validate($input)) {
        echo $input.' is not valid for REGEXP '.$regex->regex.PHP_EOL;
    }
}

validateAndExplain($regex, $input);
validateAndExplain($roman, $input);
validateAndExplain($yes, $input);
validateAndExplain($not, $input);

I know, Roman is not Regex, but I think better we do this than create a hard coded instance of Regex inside Roman::validate() which would break OOD principles too and, IMHO, worse them use inheritance in this case.

Unfortunately we also have other design problems and we have plans to use a different design (but keeping the fluent API) in the first major release.

[l-x]

Ok, I've updated the PR.

[henriquemoody]

Thank for contributing! 😄