Real PSR-4 Autoloading

[GrahamCampbell]

Replaces #181. TBH, there isn't really much merit in this, but it's here if you want it.

[GrahamCampbell]

Any news on this?

[augustohp]

Sorry for the delay, although I really appreciate your effort, I miss the point of using PSR-4 over PSR-0?

I am inclined to merge you pull request based on your effort and contribution, but do we have any concrete benefit of using one instead of another?

[augustohp]

Ping

[GrahamCampbell]

Do you want me to rebase?

[GrahamCampbell]

Ok, PSR-4 is the new standard over PSR-0, because it is more prcical and flexible. For example, it allows less directory nesting. When you install a package in composer that's PSR-0 autoloaded we end up with this sort of structure: "vendor\maintainer-name\package-name\src\MaintainerName\PackageName\Class.php". As you can see, that's quite long. A better system is PSR-4: ""vendor\maintainer-name\package-name\src\Class.php"". That smaller nesting is still useful when you are looking at the "src" folder in the repo itself too.

[GrahamCampbell]

I've rebased and added a branch alias. They are a good practice.

[GrahamCampbell]

Any news on this?

[augustohp]

Any news on this?

Sorry! Can you separate the commit of the branch alias in a stand alone commit?

[augustohp]

As you can see, that's quite long. A better system is PSR-4: ""vendor\maintainer-name\package-name\src\Class.php""

Agreed.

[GrahamCampbell]

Sure. Give me 1 sec...

[GrahamCampbell]

See #194. Also, refresh this page to see the new psr-4 commit. I force pushed it.

[augustohp]

Travis broke but I didn't check any further.

[GrahamCampbell]

Could that be linked to the package.XML being wrong? I didn't update the paths in there. Is that file even update anyway?

[alganet]

I've removed our custom autoloader from bootstrap.php and referenced only the composer autoload.php. This means that our tests depend on composer from now on. Tests are passing.

I'm not sure if we should keep the package.xml and PEAR dependencies. It seems that no one is using it.

[alganet]

Actually, hhvm is still failing. We need to figure out what to do with library/RecursiveTreeIterator.php, which hhvm does not implement. Under PSR-0 the autoload was seamless. Should we move the fallback implementation to our namespace and load under PSR-4?

[augustohp]

I'm not sure if we should keep the package.xml and PEAR dependencies. It seems that no one is using it.

It is clearly dead.

[henriquemoody]

Just a note:

I just saw that change because of some old pull requests of mine broken... PSR-0 and PSR-4 can work together, there was not need to rename the files but just update composer autoload.
Any way, that's past 😄

[GrahamCampbell]

Just rebase your pulls.

[henriquemoody]

@GrahamCampbell I already did it before comment here