Add rule "Age" to validation. #150
Conversation
|
Missing |
|
Hmn, there is a merge commit on the pull request. Could you do a |
|
Ping |
|
Any reason why you closed this? I see some confusion on the commits, If I were you I would:
PS: You may need to create another pull request for issue 190, since you are -apparently- using the same branch for both issues. |
|
@augustohp what's missing here yet? |
|
I'm sorry by our late. @malukenho, can you please rebase with our current master an update documentation (README.md and Validator docblocks)? |
|
|
||
| } elseif (!is_string($input) || (is_null($this->format) && false === strtotime($input))) { | ||
| return false; | ||
| } else { |
Instead of adding a MaximumAge rule, this creates the Age rule which incorporates both rules: minimum and maximum age. Maximum age is optional.
Fixup this commit.
This needs a fix, the "format" parameters accepted by "minimumAge"
rule is not supported by the new validator. It was supposed to be
compatible and do the exactly same thing as "minimumAge".
It would be cool to keep the same API as the "minimumAge", example:
<?php
// As it was before
v::minimumAge(18, 'Y-m-d')->validate('1990-01-01'); // true
// Needs to work that way
v::age(18, 'Y-m-d')->validate('1990-01-01'); // true
v::age(18, 65, 'Y-m-d')->validate('1990-01-01'); //true
?>
It could work that way as the `format` will always be something
acceptable by `strtotime()` function. And an `age` (an small integer)
can also be a string (Ex: "18") but is not a valid format. So, if the
second parameter is given, and is not an `is_numeric()`, it is a format.
|
|
||
| use DateTime; | ||
|
|
||
| class AgeTest extends \PHPUnit_Framework_TestCase |
There was a problem hiding this comment.
Wrong file name, also wrong path, it must be tests/Rules/AgeTest.php
There was a problem hiding this comment.
My fail, that need to be removed
|
@malukenho, I'm sorry to make you change it again, but we decided to keep BC between minor versions, so just let |
|
@malukenho, is there any progress on that issue? |
|
I could look into this if you like and get it fixed up. Unless there is something else you would rather have me work on. |
|
If @malukenho wants to pass this to another one I'm ok with that, let's just wait for his answer. |
|
@AndyWendt, since @malukenho didn't answer our question and there are 21 days since the last interaction, I'd be glad if you finish it. |
Add "Age" rule in favor of "MinimumAge".
Age rule works pretty much the same way “minimumAge”
worked but it optionally accepts a maximum age as second
argument.
See #103.
Blockers for merge
agerule on README.agerule on Validator docblocs.minimumAgerule from Validator docblocs.minimumAge(point deprecation in favor ofage).agecompatible withminimumAge.