NFe Access Key Validator

[andreyvital]

No description provided.

[nickl-]

@andreyknupp Awesome! =)

Please also update documentation if you don't mind.

[nickl-]

Oops something went wrong there and now includes commits from @alganet and @henriquemoody =(

@andreyknupp thank you for the docs!!! It all seems to be there but slightly broken.

If you would be so kind as to resubmit this PR from a fresh fork with only your changes it will simplify my tasks, otherwise I will have to investigate first.

[nickl-]

@andreyknupp I think you can fix it without going through all that effort.

Try this: (I assume that your repo is origin if you cloned from the fork.)

$ git remote add upstream https://github.com/Respect/Validation.git
$ git fetch upstream 
$ git rebase upstream/develop
$ git push origin develop

Your commits will now be on top of the latest on HEAD and if you want to "roll back" you can reset HEAD~2 to go back for the 2 commits, make the fixes you want and do new commits. This will get you out of sync with your fork as it would not have done the reset and expects to go forward only but this is not a disaster if you add --force to your push it will accept the out of sync changes.

Once you're done come look back over here, as the PR would've updated itself... like magic Ooooohhh =)

Tell us how it goes...

[augustohp]

Sweet! This indeed needs a rebase against master. If needed, I can do it (don't do it now because my internet connection sucks good time) just let me know.

@andreyknupp a question: an "nfe access key" is what (I am not familiar with NFe)? My question is target specially if the name for the rule nfe is appropriate and if nfeAccessKey is a better name.

[augustohp]

@andreyknupp I knew what NFe means, I just don't know the workings and what the access key is for, that was my question intended for. 😜

It seem like a solid PR to me 🍻! Kudos for the tests.
Could you change the name (if you still think it is relevant) and re-do the PR against master?! If you need any help, please let me know.

[augustohp]

Hey @andreyknupp I see, sorry to bother you with that after so much time. There are easier alternatives, you can checkout the pull request locally on you new fork and work on top of that.

By the way, I've done that to you so you don't have to after al; the work and patience you had with us already. 😛
I've done the rebase (against master) and the rename on #147, please let me know of any problems or issues you may find with the pull request, I will wait for you feedback to merge the PR.

PS: I am closing this in favor of #147.

[augustohp]

@andreyknupp Awesome! I merged a different pull request because it still supports 5.3 I kept you as original author since you've done all the work! 🍻

Thanks a lot for this new validator!