Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CountryCode misses DK as valid value #168

Closed
jhmilan opened this issue May 2, 2014 · 4 comments
Closed

CountryCode misses DK as valid value #168

jhmilan opened this issue May 2, 2014 · 4 comments
Labels
Milestone

Comments

@jhmilan
Copy link
Contributor

jhmilan commented May 2, 2014

We noticed 'DK' is not a valid country code, it is an expected behaviour?

https://github.com/Respect/Validation/blob/master/library/Respect/Validation/Rules/CountryCode.php#L6

Which countries are listed there?

Thank you

@filhodanuvem
Copy link
Contributor

The country list in source code

You are right @jhmilan, is missing the code of the Danmark.
Could you send a PR?

@jhmilan
Copy link
Contributor Author

jhmilan commented May 3, 2014

Will do, I'll double check other missed uso codes as well

@filhodanuvem
Copy link
Contributor

👍

augustohp pushed a commit that referenced this issue May 4, 2014
GH-168: Adds "DK" to country code validation rule.
@augustohp augustohp added the Bug label May 4, 2014
@augustohp augustohp added this to the 0.6.0 milestone May 4, 2014
@augustohp
Copy link
Member

I am considering this fixed on #168, will be released shortly on tag/version 0.6.0.

Please, let us know if you find any other missing value. If so, we can always re-open this issue or create another one.

@augustohp augustohp changed the title CountryCode validation CountryCode misses DK as valid value May 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants