Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken sf(...) Method on 0.5.0 with symfony 2.3 #139

Closed
sharpner opened this issue Dec 13, 2013 · 2 comments
Closed

Broken sf(...) Method on 0.5.0 with symfony 2.3 #139

sharpner opened this issue Dec 13, 2013 · 2 comments
Assignees
Milestone

Comments

@sharpner
Copy link

When calling:

v::create()->sf('Time')->assert('10:10');

I get this error:
Call to undefined method Symfony\Component\Validator\Constraints\TimeValidator::isValid()

Sf2 Validators use the method "validate" not isValid. I could not figure out how this could've worked in the first place.

@alganet
Copy link
Member

alganet commented Dec 22, 2013

It seems that Symfony changed their API. Back then it was called "validate" and we never tested against recent versions. I'm gonna take a look! =) Thanks for reporting!

@augustohp augustohp added this to the 0.5.1 milestone Feb 15, 2014
@augustohp augustohp modified the milestones: 0.6.0, 0.5.1 Feb 16, 2014
@augustohp augustohp self-assigned this Feb 16, 2014
@augustohp
Copy link
Member

Fixed on #139 and will be available on 0.6.0 since people using that validator on 0.5.0 with Symfony\Validator <= 0.2.1 would be suddenly affected by the compatibility break.

Tests where added to the validator so we don't keep years without noticing a problem like this!
Thanks a lot for your report @sharpner!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants