move subscriptions titles and description directly in official.json #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@myrdd what do you think? |
|
@nodiscc I think your changes are good.
This is to be discussed at RequestPolicyContinued/requestpolicy#550 |
* Suggested in RequestPolicyContinued/requestpolicy#550 * the locale.json file is referenced from official.json * the "l10n" serial in official.json should be updated every time the locale.json file is changed
|
Added fields and |
nodiscc
added a commit
that referenced
this pull request
Dec 26, 2014
move subscriptions titles and descriptions to official.json, add localized titles/descriptions in locale.json
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this can be done safely as it makes the README more readable, conveys more information directly in the subscription list, and does not break current mechanisms.