Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASL not supported? #31

Open
dkp opened this issue Feb 14, 2019 · 8 comments
Open

ASL not supported? #31

dkp opened this issue Feb 14, 2019 · 8 comments

Comments

@dkp
Copy link

dkp commented Feb 14, 2019

Hi,
We have a study that includes ASL images. The bids community suggested to me that they should be treated as func images and tagged with acq-asl. I'm having trouble getting this to work with reproin. Can reproin support such files, and if so, how should I name them?
Thanks

@laurenbreithaupt
Copy link

@dkp were you able to find a workaround for ASL images and reproin?

@yarikoptic
Copy link
Member

Unfortunately personally I have not approached ASL yet, so lack "first hand" experience.
There is BEP005 aiming to standardize ASL files naming in BIDS. So it seems that per single ASL sequence you will need to end up with multiple files.
if you could describe the details of trouble, may be we could assist to either make it compatible with BEP005 looking to go forward, or workaround somehow via those loosely defined _acq and other fields while starting with a simple func_task-YYY_run-XXX_acq-asl if you are interested in functional ASL.
Having some sample dicoms acquired on phantoms would be of help.

@dkp
Copy link
Author

dkp commented Apr 20, 2019 via email

@tsalo
Copy link

tsalo commented Jun 13, 2023

Now that ASL-BIDS has been merged, I think it might be a good time to circle back to this. Has any progress been made on ASL naming/conversion with ReproIn?

@yarikoptic
Copy link
Member

Unfortunately I had no time @tsalo and as I personally do not do ASL - no personal drive. But it must be quite easy to tune reproin for anyone who knows what to expect/want from ASL and where to place it. @dkp -- may be with all your experience with it, you could extend the https://github.com/nipy/heudiconv/blob/master/heudiconv/heuristics/reproin.py#L382 and there on to support ASL? I would be very grateful.

@dkp
Copy link
Author

dkp commented Jun 15, 2023

@yarikoptic and @tsalo Thank you for your responses! I might have too much on my plate and not enough Python experience, but I'll add it to my list, and let you know if I succeed.

@tsalo
Copy link

tsalo commented Jun 20, 2023

I think the naming could be straightforward. The two elements that concern me are (1) certain metadata fields may require user input (e.g., LabelingEfficiency) and (2) volume-wise scaling should be applied as part of the BIDS curation (e.g., GE M0 scans should be multiplied by 32 * TotalAcquiredPairs). @yarikoptic would you consider those steps within heudiconv/reproin's scrope?

@yarikoptic
Copy link
Member

Re 1: I don't think we should introduce interaction there but we could add "TODO" value.

  1. Why it isn't done by dcm2niix --bids?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants