Task/191 Remove uses of guava #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* split -r option into separate options (-K and -J) for staging repos for KZOP and JOvl * make direct imports non-optional * add direct import for javax.mail.internet * exclude JOvl from KZOP artifact (else we could ned up with two versions in the update site) * don't export the .gen package from JOvl, and mark its import in KZOP optional (would be better to not import it, but not sure how to specify that) * exclude artifacts only used by the JOvl gen package
The old one is still there, where it's always been. The new
implementation is in the val.msg package.
The new implemnetation has these improvements:
* No longer includes inline messages, but messages are identified by
enum values, and it's easy to navigate to the enum definition, where
the default message appears.
* Properties files can be used to provide localized messages, either for
a specific two-part language tag (e.g. "en-US") or by a language
id ("en") as a fallback.
* Multiple enum classes can easily be defined for different sets of
messages, and they can all be used as needed in the application
This makes it slightly more complicated to compose a new message, but
the resulting code is much more concise, and with an easy click-through
to the default message, this gets around the main issue I've had with
the eclipse org.eclipse.osgi.util.NLS class.
In the process, improved some message texts, and more importantly, created place holders in the messasge texts for message parameters, rather than just appending the paramters in a list after the message, as had been done earlier. (It was never intended to stay that way!)
This reverts commit 4428b5c. This change was intended for a separate branch
This reverts commit 5dc109b. This change was intended for a different branch
Apparently I failed update master before creating branch task/191. Sigh...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.