Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Updates to reflect latest OAS3 version #195

Closed
andylowry opened this issue Aug 24, 2018 · 1 comment
Closed

More Updates to reflect latest OAS3 version #195

andylowry opened this issue Aug 24, 2018 · 1 comment

Comments

@andylowry
Copy link
Contributor

andylowry commented Aug 24, 2018

Here we're shooting for structural compliance, e.g. implementing the Discriminator Object for schema discriminators, which in the rc0 spec were simple strings.

This is not the deep review/remediation of validation called for in #26

andylowry added a commit that referenced this issue Aug 27, 2018
[#195] Implement OAS change: Schema.discriminator is now and object, not a string
@andylowry
Copy link
Contributor Author

andylowry commented Aug 27, 2018

Implemented in #203 and #205

andylowry added a commit that referenced this issue Aug 27, 2018
Includes update to model types file, regeneration of classes, creation
of new DiscriminatorValidator, and update to SchemaValidator.

Also, fixed a bug in ValidatorBase - wrong overlay value was being
checked by the apssed validator in validateField method! Once we have
checks for unrecognized properties, that will be far more visible. (And
of course we should get validator tests!)
andylowry added a commit that referenced this issue Aug 27, 2018
[#195] Implement Discriminator object
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant