Account price based on rem.oracle #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- account price 0.5 $ in token
Alladin9393
changed the title
rem.oracle
Alladin9393
force-pushed
the
feature/account_price_based_on_oracle
branch
from
723ed51 to
3453220
Compare
…re/account_price_based_on_oracle
…mmeauth/remprotocol into feature/account_price_based_on_oracle
* fixed tests * move min_account_price from table to code * move account creation fee code to the get_min_account_stake
roman-tik
requested changes
Jan 31, 2020
| uint64_t system_contract::get_min_account_stake() { | ||
| eosio::remprice_idx remprice_table(oracle_account, oracle_account.value); | ||
| auto it = remprice_table.find(rem_usd_pair.value); | ||
| bool is_valid_price = (it != remprice_table.end()) && ((current_time_point() - it->last_update.to_time_point()) <= eosio::minutes(70)); |
There was a problem hiding this comment.
70 minutes should be parametrized, let's avoid magic numbers
There was a problem hiding this comment.
@roman-tik, done.
| auto it = remprice_table.find(rem_usd_pair.value); | ||
| bool is_valid_price = (it != remprice_table.end()) && ((current_time_point() - it->last_update.to_time_point()) <= eosio::minutes(70)); | ||
|
|
||
| return is_valid_price ? std::min(uint64_t(min_account_price / it->price), _gstate.min_account_stake) : _gstate.min_account_stake; |
There was a problem hiding this comment.
make sure uint64_t(min_account_price / it->price) != 0
There was a problem hiding this comment.
@roman-tik, done.
Alladin9393
force-pushed
the
feature/account_price_based_on_oracle
branch
from
73bf797 to
dbdd40d
Compare
roman-tik
approved these changes
Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Consensus Changes
API Changes
Documentation Additions