forked from EOSIO/eos
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change punishment transfer memo #120
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- missed blocks and pct missed blocks
…re/change_punishment_transfer_memo
Alladin9393
force-pushed
the
feature/change_punishment_transfer_memo
branch
from
December 23, 2019 17:14
c398de8
to
dd8589d
Compare
Alladin9393
force-pushed
the
feature/change_punishment_transfer_memo
branch
from
December 26, 2019 18:37
b17c5eb
to
2a8edfe
Compare
roman-tik
reviewed
Dec 26, 2019
} | ||
if ( punishment > 0 ) { | ||
double pct_missed_blocks = 100 - (prod.unpaid_blocks / double(expected_produced_blocks)) * 100; | ||
string punishment_memo = "punishment transfer: missed blocks - " + std::to_string(expected_produced_blocks - prod.unpaid_blocks) + " (" + std::to_string(pct_missed_blocks) + "%)"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
: missed XXX blocks out of YYY
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roman-tik, done.
Alladin9393
force-pushed
the
feature/change_punishment_transfer_memo
branch
2 times, most recently
from
December 27, 2019 12:43
29de6da
to
289960a
Compare
Alladin9393
force-pushed
the
feature/change_punishment_transfer_memo
branch
from
December 27, 2019 15:01
289960a
to
c9163cb
Compare
…re/change_punishment_transfer_memo
roman-tik
approved these changes
Dec 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Example
punishment transfer: missed blocks - 116 (4.221200%)