Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Plex lifecycle management #40

Merged
merged 2 commits into from
May 13, 2022
Merged

Add Plex lifecycle management #40

merged 2 commits into from
May 13, 2022

Conversation

RemiRigal
Copy link
Owner

This PR implements changes suggested in #33.

It improves the integration with the Plex lifecycle (restarts, upgrades...), the goal being to be closer to a "setup and forget" application.

Changes:

  • PAL will now try multiple times to connect to the Plex server
  • PAL will try to restore the connection with the Plex server when lost

@codecov-commenter
Copy link

Codecov Report

Merging #40 (12de097) into master (025def0) will increase coverage by 0.70%.
The diff coverage is 86.27%.

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
+ Coverage   93.11%   93.81%   +0.70%     
==========================================
  Files          18       18              
  Lines         915      954      +39     
==========================================
+ Hits          852      895      +43     
+ Misses         63       59       -4     
Flag Coverage Δ
claimed 93.81% <86.27%> (+0.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plex_auto_languages/plex_server.py 84.93% <83.72%> (+5.04%) ⬆️
plex_auto_languages/utils/json.py 100.00% <100.00%> (ø)
plex_auto_languages/utils/scheduler.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 025def0...12de097. Read the comment docs.

@RemiRigal RemiRigal merged commit 31f0926 into master May 13, 2022
@RemiRigal RemiRigal deleted the feature/plex_lifecycle branch May 13, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants