Enhancement: Fallback to SysDriveRoot on Install if OneDrive detected

[dreamsyntax]

Makes the Reloaded-II initial installation fallback to SysDriveRoot (commonly C:) if OneDrive is detected in the path to the user's Desktop.
Resolves #477

[dreamsyntax]

Confirmed on Win 10 22H2 with OneDrive disabled / with recommended backup mode off, such that Desktop is not within [..]\OneDrive\ that the Installer successfully put Reloaded-II on C:\Users\myuser\Desktop

Confirmed on Win 11 24H2 with OneDrive "recommended backup" mode, which re-links Desktop that the Installer successfully put Reloaded-II on C:\ instead.

[Sewer56]

Just as a quick check, does the launcher work fine after install?
I'm more so curious as I don't know if a non-admin user would have write permissions to that folder. I believe they should, but since you have a VM, might aswell doublecheck.

[dreamsyntax]

Just as a quick check, does the launcher work fine after install?
I'm more so curious as I don't know if a non-admin user would have write permissions to that folder. I believe they should, but since you have a VM, might aswell doublecheck.

Would it need to be installed by a non admin user? I rarely if ever see non admin users used on windows

[Sewer56]

Yeah pretty much, non-admin user. It's rare but it exists.

[dreamsyntax]

Non-Admin user experience is pretty broken it seems.
Flow was this:

Precondition:

• Admin user exists with OneDrive setup, and password/pin - Reloaded-II never previously installed
• Standard (non admin) user exists and does not have OneDrive setup.
• Standard user is currently logged in.

Steps:

1. Standard user runs Setup.exe. UAC asks to elevate to admin and requires Admin user's credentials.
2. Admin user authorizes.
3. Reloaded-II installer detects Admin User's OneDrive path to Desktop, since it's run under Admin context, and places Reloaded-II in C:\Reloaded-II
4. No Shortcut to Reloaded-II is created on Standard User's Desktop. The Shortcut is instead placed on Admin's Desktop.
5. Reloaded-II finishes launching, and is fully functional with Mod Downloads, Launching, etc.
6. Reloaded-II is closed by the Standard User.
7. Reloaded-II is directly launched by the Standard User by navigating to C:\Reloaded-II
8. The program does not successfully initialize.
   

There's a lot wrong.

Context is based on the Elevated Admin permissions, causing:

• Shortcut is placed on Admin's Desktop instead of Standard User.
• OneDrive detection is based on the Admin instead of Standard User.
• Reloaded-II will work (because its running in the Admin user's context) until next launch.

I think perhaps this is an edgecase that could be isolated separately in another Issue/PR.
Ideally we'd just warn the user to instead use the Release.zip in the case of a non-admin account AND somehow detect a different user's context is used for the redist setups when the context is elevated for installing those.

[Sewer56]

Well, for now a non-admin account wouldn't be able to elevate to admin to run the installer in any case; without some very special setup; that's fine to leave to another issue then.