Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add void signature to functions which take no arguments #81

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

d-netto
Copy link
Member

@d-netto d-netto commented Sep 27, 2023

PR Description

See title. CC complains about this.

Checklist

Requirements for merging:

  • I have opened an issue or PR upstream on JuliaLang/julia: not applicable, since these functions are not defined in stock Julia.
  • I have removed the port-to-* labels that don't apply.

@github-actions github-actions bot added port-to-v1.10 This change should apply to Julia v1.10 builds port-to-master This change should apply to all future Julia builds port-to-v1.9 This change should apply to Julia v1.9 builds labels Sep 27, 2023
@kpamnany
Copy link
Collaborator

kpamnany commented Sep 28, 2023

Since this is a tiny change, I think we can just merge it. But FYI @d-netto, the new process (e.g. in #83) has us creating a PR in RAICode (e.g. https://github.com/RelationalAI/raicode/pull/15683), linking it to the PR description here and confirming that RAICode is green with the change before merging.

Edit: then, we have to go back to the RAICode PR and change back nix/julia-version.json before merging that.

@NHDaly NHDaly merged commit 2c547fa into v1.9.2+RAI Oct 11, 2023
@NHDaly NHDaly deleted the dcn-void-sig-on-no-arg-fn branch October 11, 2023 22:34
@kpamnany kpamnany removed the port-to-v1.9 This change should apply to Julia v1.9 builds label Oct 19, 2023
@kpamnany kpamnany removed the port-to-v1.10 This change should apply to Julia v1.10 builds label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
port-to-master This change should apply to all future Julia builds
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants