forked from JuliaLang/julia
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functions to allow "external" memory registration #6
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe I get the intent, but not sure it's possible to grab and compare all of
jl_all_tls_states
like this?jl_atomic_load_relaxed
works on a single atomic value, and there'd be no way to atomically load or compare the values from all threads at once, would there? And I suspectcombine_thread_gc_counts
below is either incorrect or is behind a locking synchronization point?I'm trying to recall for sure if per-thread allocd being off balance was a concern or not and what led to me writing this. It's possible just sticking it in the current thread and letting
combine_thread_gc_counts
work it out is good enough.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, my comments are only relevant for Julia 1.9 and up.
jl_all_tls_states
is not an_Atomic
in 1.8.2, so you can ignore all that.To address your question anyway -- in 1.9, it is possible to add "foreign" threads through the Julia C library interface. When that happens, a new
jl_ptls_t *
array is created andjl_all_tls_states
is atomically switched to point at the new array -- the old array is lazily freed. So my suggestions were basically about checking to see ifjl_all_tls_states
changed underneath us while we were doing our updates and if it did, to redo them.@d-netto agreed with the need to partition the
allocd
across threads, FWIW, maybe he can clarify on that question.Also, there are plans afoot to make changes to the GC's heuristics --
default_collect_interval
may go away altogether. So if we're not immediately using the calls to adjust it, let's drop them from this patch to keep it minimal.