Add nightly rebase of branches with upstream julia #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickrobinson251
approved these changes
Sep 8, 2023
| with: | ||
| affected_service: Engineering - Julia Upgrades - Medium Priority Only | ||
| summary: "Nightly rebase failed for RelationalAI/julia branch `${{ matrix.julia_branch.name }}`" | ||
| description: "Failed to rebase RelationalAI/julia branch `${{ matrix.julia_branch.name }}` branch on top of `${{ matrix.julia_branch.upstream}}`.\nPlease manually rebase ${{ matrix.julia_branch.name }}\n" |
There was a problem hiding this comment.
should we have persistent open PRs for v1.x+RAI -> v1.x, so that we can easily see the diff and so also easily see the merge conflicts / any rebase mishaps in the GitHub UI? I think that'd be helpful. If we do, then i think it'd also be helpful to link the PR here too
There was a problem hiding this comment.
Like, open a PR from backports-release-1.9+RAI -> backports-release-1.9? Or backports-release-1.9+RAI -> v1.9.3? For the former, I think the PR would open upstream, which we wouldn't want. For the latter, it would show us the diff of commits that have been proposed in the next patch release + the patches we're carrying; is that what you're thinking? If so, I think that could be useful, yes.
There was a problem hiding this comment.
ah, right
Like, open a PR from backports-release-1.9+RAI -> backports-release-1.9
i was thinking this, but i meant a PR on this repo (not upstream), but that's because i was forgetting we aren't also keeping backports-release-1.9 up-to-date with upstream backports-release-1.9. i.e. the PR diff would just show our patches to v1.9
why aren't we keeping backports-release-1.9 up to date? couldn't we just git pull each day (it's not like we need to run tests)?
Or backports-release-1.9+RAI -> v1.9.3? ...it would show us the diff of commits that have been proposed in the next patch release + the patches we're carrying
that does sound kinda useful too, now you mention it 😆 But i'm more worried about seeing our changes than i am what's already in the upcoming Julia release from upstream
There was a problem hiding this comment.
Ok, I opened PRs between backports-release-1.9+RAI and v1.9.3+RAI for now so we can see the total diff of: 1) incoming changes that are proposed for next patch release and 2) our own patches we're carrying for the branch. They're now linked in the GHA failure mode and should make it easy to compare diffs.
Co-authored-by: Nick Robinson <[email protected]>
Co-authored-by: Nick Robinson <[email protected]>
Co-authored-by: Nick Robinson <[email protected]>
DelveCI
pushed a commit
that referenced
this pull request
Sep 14, 2023
* Add nightly rebase of branches with upstream julia * Update .github/workflows/nightly-rebase-upstream.yml Co-authored-by: Nick Robinson <[email protected]> * Update .github/workflows/nightly-rebase-upstream.yml Co-authored-by: Nick Robinson <[email protected]> * Update .github/workflows/nightly-rebase-upstream.yml Co-authored-by: Nick Robinson <[email protected]> * Updates --------- Co-authored-by: Nick Robinson <[email protected]>
DelveCI
pushed a commit
that referenced
this pull request
Sep 14, 2023
* Add nightly rebase of branches with upstream julia * Update .github/workflows/nightly-rebase-upstream.yml Co-authored-by: Nick Robinson <[email protected]> * Update .github/workflows/nightly-rebase-upstream.yml Co-authored-by: Nick Robinson <[email protected]> * Update .github/workflows/nightly-rebase-upstream.yml Co-authored-by: Nick Robinson <[email protected]> * Updates --------- Co-authored-by: Nick Robinson <[email protected]>
nickrobinson251
added a commit
that referenced
this pull request
Sep 14, 2023
This reverts commit a3e016c.
nickrobinson251
added a commit
that referenced
this pull request
Sep 14, 2023
Revert "Add nightly rebase of branches with upstream julia (#42)"
DelveCI
pushed a commit
that referenced
this pull request
Sep 15, 2023
* Add nightly rebase of branches with upstream julia * Update .github/workflows/nightly-rebase-upstream.yml Co-authored-by: Nick Robinson <[email protected]> * Update .github/workflows/nightly-rebase-upstream.yml Co-authored-by: Nick Robinson <[email protected]> * Update .github/workflows/nightly-rebase-upstream.yml Co-authored-by: Nick Robinson <[email protected]> * Updates --------- Co-authored-by: Nick Robinson <[email protected]>
DelveCI
pushed a commit
that referenced
this pull request
Sep 15, 2023
* Add nightly rebase of branches with upstream julia * Update .github/workflows/nightly-rebase-upstream.yml Co-authored-by: Nick Robinson <[email protected]> * Update .github/workflows/nightly-rebase-upstream.yml Co-authored-by: Nick Robinson <[email protected]> * Update .github/workflows/nightly-rebase-upstream.yml Co-authored-by: Nick Robinson <[email protected]> * Updates --------- Co-authored-by: Nick Robinson <[email protected]>
DelveCI
pushed a commit
that referenced
this pull request
Sep 18, 2023
* Add nightly rebase of branches with upstream julia * Update .github/workflows/nightly-rebase-upstream.yml Co-authored-by: Nick Robinson <[email protected]> * Update .github/workflows/nightly-rebase-upstream.yml Co-authored-by: Nick Robinson <[email protected]> * Update .github/workflows/nightly-rebase-upstream.yml Co-authored-by: Nick Robinson <[email protected]> * Updates --------- Co-authored-by: Nick Robinson <[email protected]>
DelveCI
pushed a commit
that referenced
this pull request
Sep 18, 2023
* Add nightly rebase of branches with upstream julia * Update .github/workflows/nightly-rebase-upstream.yml Co-authored-by: Nick Robinson <[email protected]> * Update .github/workflows/nightly-rebase-upstream.yml Co-authored-by: Nick Robinson <[email protected]> * Update .github/workflows/nightly-rebase-upstream.yml Co-authored-by: Nick Robinson <[email protected]> * Updates --------- Co-authored-by: Nick Robinson <[email protected]>
DelveCI
pushed a commit
that referenced
this pull request
Sep 19, 2023
* Add nightly rebase of branches with upstream julia * Update .github/workflows/nightly-rebase-upstream.yml Co-authored-by: Nick Robinson <[email protected]> * Update .github/workflows/nightly-rebase-upstream.yml Co-authored-by: Nick Robinson <[email protected]> * Update .github/workflows/nightly-rebase-upstream.yml Co-authored-by: Nick Robinson <[email protected]> * Updates --------- Co-authored-by: Nick Robinson <[email protected]>
DelveCI
pushed a commit
that referenced
this pull request
Sep 20, 2023
* Add nightly rebase of branches with upstream julia * Update .github/workflows/nightly-rebase-upstream.yml Co-authored-by: Nick Robinson <[email protected]> * Update .github/workflows/nightly-rebase-upstream.yml Co-authored-by: Nick Robinson <[email protected]> * Update .github/workflows/nightly-rebase-upstream.yml Co-authored-by: Nick Robinson <[email protected]> * Updates --------- Co-authored-by: Nick Robinson <[email protected]>
DelveCI
pushed a commit
that referenced
this pull request
Sep 21, 2023
* Add nightly rebase of branches with upstream julia * Update .github/workflows/nightly-rebase-upstream.yml Co-authored-by: Nick Robinson <[email protected]> * Update .github/workflows/nightly-rebase-upstream.yml Co-authored-by: Nick Robinson <[email protected]> * Update .github/workflows/nightly-rebase-upstream.yml Co-authored-by: Nick Robinson <[email protected]> * Updates --------- Co-authored-by: Nick Robinson <[email protected]>
DelveCI
pushed a commit
that referenced
this pull request
Sep 22, 2023
* Add nightly rebase of branches with upstream julia * Update .github/workflows/nightly-rebase-upstream.yml Co-authored-by: Nick Robinson <[email protected]> * Update .github/workflows/nightly-rebase-upstream.yml Co-authored-by: Nick Robinson <[email protected]> * Update .github/workflows/nightly-rebase-upstream.yml Co-authored-by: Nick Robinson <[email protected]> * Updates --------- Co-authored-by: Nick Robinson <[email protected]>
DelveCI
pushed a commit
that referenced
this pull request
Sep 22, 2023
* Add nightly rebase of branches with upstream julia * Update .github/workflows/nightly-rebase-upstream.yml Co-authored-by: Nick Robinson <[email protected]> * Update .github/workflows/nightly-rebase-upstream.yml Co-authored-by: Nick Robinson <[email protected]> * Update .github/workflows/nightly-rebase-upstream.yml Co-authored-by: Nick Robinson <[email protected]> * Updates --------- Co-authored-by: Nick Robinson <[email protected]>
DelveCI
pushed a commit
that referenced
this pull request
Sep 23, 2023
* Add nightly rebase of branches with upstream julia * Update .github/workflows/nightly-rebase-upstream.yml Co-authored-by: Nick Robinson <[email protected]> * Update .github/workflows/nightly-rebase-upstream.yml Co-authored-by: Nick Robinson <[email protected]> * Update .github/workflows/nightly-rebase-upstream.yml Co-authored-by: Nick Robinson <[email protected]> * Updates --------- Co-authored-by: Nick Robinson <[email protected]>
DelveCI
pushed a commit
that referenced
this pull request
Sep 24, 2023
* Add nightly rebase of branches with upstream julia * Update .github/workflows/nightly-rebase-upstream.yml Co-authored-by: Nick Robinson <[email protected]> * Update .github/workflows/nightly-rebase-upstream.yml Co-authored-by: Nick Robinson <[email protected]> * Update .github/workflows/nightly-rebase-upstream.yml Co-authored-by: Nick Robinson <[email protected]> * Updates --------- Co-authored-by: Nick Robinson <[email protected]>
DelveCI
pushed a commit
that referenced
this pull request
Sep 25, 2023
* Add nightly rebase of branches with upstream julia * Update .github/workflows/nightly-rebase-upstream.yml Co-authored-by: Nick Robinson <[email protected]> * Update .github/workflows/nightly-rebase-upstream.yml Co-authored-by: Nick Robinson <[email protected]> * Update .github/workflows/nightly-rebase-upstream.yml Co-authored-by: Nick Robinson <[email protected]> * Updates --------- Co-authored-by: Nick Robinson <[email protected]>
DelveCI
pushed a commit
that referenced
this pull request
Sep 26, 2023
* Add nightly rebase of branches with upstream julia * Update .github/workflows/nightly-rebase-upstream.yml Co-authored-by: Nick Robinson <[email protected]> * Update .github/workflows/nightly-rebase-upstream.yml Co-authored-by: Nick Robinson <[email protected]> * Update .github/workflows/nightly-rebase-upstream.yml Co-authored-by: Nick Robinson <[email protected]> * Updates --------- Co-authored-by: Nick Robinson <[email protected]>
nickrobinson251
added a commit
that referenced
this pull request
Sep 26, 2023
* Add nightly rebase of branches with upstream julia * Update .github/workflows/nightly-rebase-upstream.yml Co-authored-by: Nick Robinson <[email protected]> * Update .github/workflows/nightly-rebase-upstream.yml Co-authored-by: Nick Robinson <[email protected]> * Update .github/workflows/nightly-rebase-upstream.yml Co-authored-by: Nick Robinson <[email protected]> * Updates --------- Co-authored-by: Nick Robinson <[email protected]>
nickrobinson251
added a commit
that referenced
this pull request
Sep 26, 2023
This reverts commit a3e016c.
NHDaly
pushed a commit
that referenced
this pull request
May 17, 2024
Without this change, the compiler fails to notice that `env_threads isa Int` in the fall-through case, leading to a union-split with a branch that is in fact unreachable: ``` 43 ┄ %109 = φ (#41 => %105, #42 => %108)::Union{Nothing, Int64} │ %110 = (%109 isa Int64)::Bool └─── goto #45 if not %110 ... 45 ─ %126 = π (%109, Nothing) │ Base.convert(Int64, %126)::Union{} └─── unreachable ``` After this change, the union-split is eliminated. Co-authored-by: Jeff Bezanson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm opening this PR against the
master+RAIbranch, which I think we should switch as the "default" branch of this repo.