Fix trampoline assembly for build on clang 18 on apple silicon (#54634) #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Lang#54634) This avoids a: `error: non-private labels cannot appear between .cfi_startproc / .cfi_endproc pairs` error. That error was introduced in https://reviews.llvm.org/D155245#4657075 see also llvm/llvm-project#72802 (cherry picked from commit a4e793e) (cherry picked from commit 3f35094)
github-actions
bot
added
port-to-v1.10
rbvermaa
approved these changes
Nov 19, 2024
|
Could you provide some higher-level context on why we are backporting this? I.e. does this fixe any bug related to building raicode with PackageCompiler on Apple silicon? (That's what I imagine...) |
|
@d-netto Sorry, here is a slack thread for context: https://relationalai.slack.com/archives/C04J1BRVD40/p1731383171631329 TL;DR: with newer clang that came with the recent Sonoma upgrade, we couldn't get Julia 1.10.2 or 1.10.2+RAI to build on Apple silicon (they fixed it in Julia 1.10.5) |
d-netto
approved these changes
Nov 19, 2024
Drvi
removed
port-to-v1.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids a:
error: non-private labels cannot appear between .cfi_startproc / .cfi_endproc pairserror.That error was introduced in https://reviews.llvm.org/D155245#4657075 see also llvm/llvm-project#72802
(cherry picked from commit a4e793e) (cherry picked from commit 3f35094)
PR Description
What does this PR do?
Checklist
Requirements for merging:
port-to-*labels that don't apply.