Change to streaming out the heap snapshot data #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Streaming the heap snapshot! This should prevent the engine from OOMing while recording the snapshot! Now we just need to sample the files, either online, before downloading, or offline after downloading :) If we're gonna do it offline, we'll want to gzip the files before downloading them. * Allow custom filename; use original API * Support legacy heap snapshot interface. Add reassembly function. * Add tests * Apply suggestions from code review * Update src/gc-heap-snapshot.cpp * Change to always save the parts in the same directory This way you can always recover from an OOM * Fix bug in reassembler: from_node and to_node were in the wrong order * Fix correctness mistake: The edges have to be reordered according to the node order. That's the whole reason this is tricky. But i'm not sure now whether the SoAs approach is actually an optimization.... It seems like we should probably prefer to inline the Edges right into the vector, rather than having to do another random lookup into the edges table? * Debugging messed up edge array idxs * Disable log message * Write the .nodes and .edges as binary data * Remove unnecessary logging * fix merge issues * attempt to add back the orphan node checking logic --------- Co-authored-by: Nathan Daly <[email protected]> Co-authored-by: Nathan Daly <[email protected]>
github-actions
bot
added
port-to-v1.10
JianFangAtRai
removed
port-to-v1.10
|
Requirements for merging: I have opened an issue or PR upstream on JuliaLang/julia: JuliaLang#52854 |
remove unused k_node_number_of_fields from gc-heap-snapshot.cpp attempt to resolve the savepoint issue on serialize_node
NHDaly
added
port-to-v1.10
|
I think this actually does need to be ported to 1.10, since we'll want this in our 1.10 branch as well. Thanks for commenting on what you changed, that was helpful. |
dedupling strings for field paths
JianFangAtRai
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should prevent the engine from OOMing while recording the snapshot!
Now we just need to sample the files, either online, before downloading, or offline after downloading :)
If we're gonna do it offline, we'll want to gzip the files before downloading them.
Allow custom filename; use original API
Support legacy heap snapshot interface. Add reassembly function.
Add tests
Apply suggestions from code review
Update src/gc-heap-snapshot.cpp
Change to always save the parts in the same directory
This way you can always recover from an OOM
Fix bug in reassembler: from_node and to_node were in the wrong order
Fix correctness mistake: The edges have to be reordered according to the node order. That's the whole reason this is tricky.
But i'm not sure now whether the SoAs approach is actually an optimization.... It seems like we should probably prefer to inline the Edges right into the vector, rather than having to do another random lookup into the edges table?
Debugging messed up edge array idxs
Disable log message
Write the .nodes and .edges as binary data
Remove unnecessary logging
fix merge issues
attempt to add back the orphan node checking logic
PR Description
What does this PR do?
Checklist
Requirements for merging:
port-to-*labels that don't apply.