Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert GC heuristics back to 1.9 #126

Merged
merged 1 commit into from
Jan 4, 2024
Merged

revert GC heuristics back to 1.9 #126

merged 1 commit into from
Jan 4, 2024

Conversation

d-netto
Copy link
Member

@d-netto d-netto commented Jan 2, 2024 •
edited
Loading

PR Description

We'll likely be running with 1.9 GC heuristics on top of 1.10.

Checklist

Requirements for merging:

@d-netto d-netto requested a review from kpamnany January 2, 2024 18:10
@d-netto
Copy link
Member Author

d-netto commented Jan 2, 2024

FYI, tested this on the serial GCBenchmarks and it looks fine:

  • 1.9.2+RAI:
category = "TimeZones"
bench = "TimeZones.jl"
┌─────────┬────────────┬─────────┬───────────┬────────────┬──────────────┬───────────────────┬──────────┬────────────┐
│         │ total time │ gc time │ mark time │ sweep time │ max GC pause │ time to safepoint │ max heap │ percent gc │
│         │         ms │      ms │        ms │         ms │           ms │                us │       MB │          % │
├─────────┼────────────┼─────────┼───────────┼────────────┼──────────────┼───────────────────┼──────────┼────────────┤
│ minimum │        667 │     196 │       191 │          5 │           91 │                22 │     5100 │         29 │
│  median │        679 │     200 │       195 │          5 │           93 │                25 │     5100 │         30 │
│ maximum │        694 │     210 │       202 │          7 │          106 │                28 │     5100 │         31 │
│   stdev │         10 │       6 │         5 │          1 │            6 │                 3 │        0 │          1 │
└─────────┴────────────┴─────────┴───────────┴────────────┴──────────────┴───────────────────┴──────────┴────────────┘
category = "append"
bench = "append.jl"
┌─────────┬────────────┬─────────┬───────────┬────────────┬──────────────┬───────────────────┬──────────┬────────────┐
│         │ total time │ gc time │ mark time │ sweep time │ max GC pause │ time to safepoint │ max heap │ percent gc │
│         │         ms │      ms │        ms │         ms │           ms │                us │       MB │          % │
├─────────┼────────────┼─────────┼───────────┼────────────┼──────────────┼───────────────────┼──────────┼────────────┤
│ minimum │        762 │      59 │         9 │         49 │           35 │               116 │     1481 │          7 │
│  median │        776 │      62 │        10 │         53 │           41 │               138 │     1481 │          8 │
│ maximum │        823 │      68 │        10 │         58 │           41 │               160 │     1481 │          9 │
│   stdev │         24 │       4 │         1 │          4 │            3 │                20 │        0 │          1 │
└─────────┴────────────┴─────────┴───────────┴────────────┴──────────────┴───────────────────┴──────────┴────────────┘
category = "bigint"
bench = "pollard.jl"
┌─────────┬────────────┬─────────┬───────────┬────────────┬──────────────┬───────────────────┬──────────┬────────────┐
│         │ total time │ gc time │ mark time │ sweep time │ max GC pause │ time to safepoint │ max heap │ percent gc │
│         │         ms │      ms │        ms │         ms │           ms │                us │       MB │          % │
├─────────┼────────────┼─────────┼───────────┼────────────┼──────────────┼───────────────────┼──────────┼────────────┤
│ minimum │        427 │     113 │         8 │          9 │           35 │                42 │      123 │         23 │
│  median │        430 │     115 │         9 │         10 │           36 │                48 │      123 │         26 │
│ maximum │        496 │     121 │        10 │         10 │           37 │                54 │      124 │         27 │
│   stdev │         29 │       3 │         1 │          0 │            1 │                 5 │        0 │          1 │
└─────────┴────────────┴─────────┴───────────┴────────────┴──────────────┴───────────────────┴──────────┴────────────┘
category = "linked"
bench = "list.jl"
┌─────────┬────────────┬─────────┬───────────┬────────────┬──────────────┬───────────────────┬──────────┬────────────┐
│         │ total time │ gc time │ mark time │ sweep time │ max GC pause │ time to safepoint │ max heap │ percent gc │
│         │         ms │      ms │        ms │         ms │           ms │                us │       MB │          % │
├─────────┼────────────┼─────────┼───────────┼────────────┼──────────────┼───────────────────┼──────────┼────────────┤
│ minimum │       2332 │    1682 │      1562 │        114 │          560 │                58 │     2799 │         72 │
│  median │       2376 │    1733 │      1600 │        131 │          568 │                72 │     2799 │         73 │
│ maximum │       2392 │    1745 │      1614 │        138 │          585 │                85 │     2803 │         73 │
│   stdev │         28 │      27 │        24 │          9 │           11 │                10 │        2 │          0 │
└─────────┴────────────┴─────────┴───────────┴────────────┴──────────────┴───────────────────┴──────────┴────────────┘
bench = "tree.jl"
┌─────────┬────────────┬─────────┬───────────┬────────────┬──────────────┬───────────────────┬──────────┬────────────┐
│         │ total time │ gc time │ mark time │ sweep time │ max GC pause │ time to safepoint │ max heap │ percent gc │
│         │         ms │      ms │        ms │         ms │           ms │                us │       MB │          % │
├─────────┼────────────┼─────────┼───────────┼────────────┼──────────────┼───────────────────┼──────────┼────────────┤
│ minimum │       2873 │     313 │       309 │          4 │          225 │                22 │      139 │         11 │
│  median │       3085 │     359 │       355 │          4 │          255 │                23 │      139 │         12 │
│ maximum │       3410 │     408 │       403 │          5 │          298 │                29 │      139 │         13 │
│   stdev │        192 │      41 │        40 │          0 │           28 │                 3 │        0 │          1 │
└─────────┴────────────┴─────────┴───────────┴────────────┴──────────────┴───────────────────┴──────────┴────────────┘
category = "obj_arrays"
bench = "many_refs.jl"
┌─────────┬────────────┬─────────┬───────────┬────────────┬──────────────┬───────────────────┬──────────┬────────────┐
│         │ total time │ gc time │ mark time │ sweep time │ max GC pause │ time to safepoint │ max heap │ percent gc │
│         │         ms │      ms │        ms │         ms │           ms │                us │       MB │          % │
├─────────┼────────────┼─────────┼───────────┼────────────┼──────────────┼───────────────────┼──────────┼────────────┤
│ minimum │       1093 │     920 │       855 │         65 │          299 │                13 │      868 │         84 │
│  median │       1097 │     929 │       863 │         66 │          304 │                15 │      869 │         85 │
│ maximum │       1110 │     936 │       870 │         66 │          305 │                16 │      869 │         85 │
│   stdev │          7 │       6 │         6 │          0 │            2 │                 1 │        0 │          0 │
└─────────┴────────────┴─────────┴───────────┴────────────┴──────────────┴───────────────────┴──────────┴────────────┘
bench = "single_ref.jl"
┌─────────┬────────────┬─────────┬───────────┬────────────┬──────────────┬───────────────────┬──────────┬────────────┐
│         │ total time │ gc time │ mark time │ sweep time │ max GC pause │ time to safepoint │ max heap │ percent gc │
│         │         ms │      ms │        ms │         ms │           ms │                us │       MB │          % │
├─────────┼────────────┼─────────┼───────────┼────────────┼──────────────┼───────────────────┼──────────┼────────────┤
│ minimum │        466 │     327 │       318 │          8 │          115 │                16 │      868 │         70 │
│  median │        467 │     328 │       319 │          9 │          116 │                18 │      868 │         70 │
│ maximum │        471 │     330 │       322 │          9 │          117 │                23 │      868 │         71 │
│   stdev │          2 │       1 │         1 │          0 │            1 │                 3 │        0 │          0 │
└─────────┴────────────┴─────────┴───────────┴────────────┴──────────────┴───────────────────┴──────────┴────────────┘
category = "strings"
bench = "strings.jl"
┌─────────┬────────────┬─────────┬───────────┬────────────┬──────────────┬───────────────────┬──────────┬────────────┐
│         │ total time │ gc time │ mark time │ sweep time │ max GC pause │ time to safepoint │ max heap │ percent gc │
│         │         ms │      ms │        ms │         ms │           ms │                us │       MB │          % │
├─────────┼────────────┼─────────┼───────────┼────────────┼──────────────┼───────────────────┼──────────┼────────────┤
│ minimum │      14304 │    1643 │      1379 │        264 │           36 │               416 │      584 │         11 │
│  median │      14943 │    1748 │      1474 │        274 │           36 │               525 │      584 │         12 │
│ maximum │      15248 │    1818 │      1541 │        278 │           45 │               556 │      584 │         12 │
│   stdev │        394 │      65 │        60 │          6 │            4 │                60 │        0 │          0 │
└─────────┴────────────┴─────────┴───────────┴────────────┴──────────────┴───────────────────┴──────────┴────────────┘
  • PR:
category = "TimeZones"
bench = "TimeZones.jl"
┌─────────┬────────────┬─────────┬───────────┬────────────┬──────────────┬───────────────────┬──────────┬────────────┐
│         │ total time │ gc time │ mark time │ sweep time │ max GC pause │ time to safepoint │ max heap │ percent gc │
│         │         ms │      ms │        ms │         ms │           ms │                us │       MB │          % │
├─────────┼────────────┼─────────┼───────────┼────────────┼──────────────┼───────────────────┼──────────┼────────────┤
│ minimum │        668 │     196 │       191 │          5 │           92 │                21 │     5101 │         29 │
│  median │        675 │     199 │       194 │          5 │           94 │                22 │     5101 │         30 │
│ maximum │        690 │     205 │       199 │          6 │           99 │                27 │     5101 │         30 │
│   stdev │          9 │       4 │         3 │          1 │            3 │                 3 │        0 │          0 │
└─────────┴────────────┴─────────┴───────────┴────────────┴──────────────┴───────────────────┴──────────┴────────────┘
category = "append"
bench = "append.jl"
┌─────────┬────────────┬─────────┬───────────┬────────────┬──────────────┬───────────────────┬──────────┬────────────┐
│         │ total time │ gc time │ mark time │ sweep time │ max GC pause │ time to safepoint │ max heap │ percent gc │
│         │         ms │      ms │        ms │         ms │           ms │                us │       MB │          % │
├─────────┼────────────┼─────────┼───────────┼────────────┼──────────────┼───────────────────┼──────────┼────────────┤
│ minimum │        824 │      64 │         9 │         53 │           37 │               166 │     1481 │          8 │
│  median │        836 │      66 │        10 │         55 │           41 │               191 │     1481 │          8 │
│ maximum │        851 │      66 │        11 │         57 │           47 │               210 │     1481 │          8 │
│   stdev │          9 │       1 │         1 │          2 │            4 │                16 │        0 │          0 │
└─────────┴────────────┴─────────┴───────────┴────────────┴──────────────┴───────────────────┴──────────┴────────────┘
category = "bigint"
bench = "pollard.jl"
┌─────────┬────────────┬─────────┬───────────┬────────────┬──────────────┬───────────────────┬──────────┬────────────┐
│         │ total time │ gc time │ mark time │ sweep time │ max GC pause │ time to safepoint │ max heap │ percent gc │
│         │         ms │      ms │        ms │         ms │           ms │                us │       MB │          % │
├─────────┼────────────┼─────────┼───────────┼────────────┼──────────────┼───────────────────┼──────────┼────────────┤
│ minimum │        449 │     114 │       104 │         10 │           33 │                55 │      124 │         18 │
│  median │        463 │     115 │       105 │         10 │           40 │                57 │      124 │         25 │
│ maximum │        657 │     125 │       114 │         12 │           44 │                89 │      124 │         27 │
│   stdev │         89 │       5 │         4 │          1 │            5 │                14 │        0 │          4 │
└─────────┴────────────┴─────────┴───────────┴────────────┴──────────────┴───────────────────┴──────────┴────────────┘
category = "linked"
bench = "list.jl"
┌─────────┬────────────┬─────────┬───────────┬────────────┬──────────────┬───────────────────┬──────────┬────────────┐
│         │ total time │ gc time │ mark time │ sweep time │ max GC pause │ time to safepoint │ max heap │ percent gc │
│         │         ms │      ms │        ms │         ms │           ms │                us │       MB │          % │
├─────────┼────────────┼─────────┼───────────┼────────────┼──────────────┼───────────────────┼──────────┼────────────┤
│ minimum │       2372 │    1712 │      1582 │        130 │          567 │                70 │     3145 │         72 │
│  median │       2454 │    1791 │      1612 │        175 │          592 │                80 │     3148 │         73 │
│ maximum │       2487 │    1814 │      1634 │        192 │          614 │                94 │     3148 │         73 │
│   stdev │         53 │      49 │        23 │         28 │           21 │                10 │        2 │          0 │
└─────────┴────────────┴─────────┴───────────┴────────────┴──────────────┴───────────────────┴──────────┴────────────┘
bench = "tree.jl"
┌─────────┬────────────┬─────────┬───────────┬────────────┬──────────────┬───────────────────┬──────────┬────────────┐
│         │ total time │ gc time │ mark time │ sweep time │ max GC pause │ time to safepoint │ max heap │ percent gc │
│         │         ms │      ms │        ms │         ms │           ms │                us │       MB │          % │
├─────────┼────────────┼─────────┼───────────┼────────────┼──────────────┼───────────────────┼──────────┼────────────┤
│ minimum │       2599 │     270 │       265 │          4 │          189 │                27 │      123 │          9 │
│  median │       3419 │     329 │       325 │          5 │          230 │                31 │      123 │         10 │
│ maximum │       3491 │     348 │       343 │          5 │          259 │                36 │      123 │         10 │
│   stdev │        375 │      32 │        32 │          0 │           28 │                 4 │        0 │          0 │
└─────────┴────────────┴─────────┴───────────┴────────────┴──────────────┴───────────────────┴──────────┴────────────┘
category = "obj_arrays"
bench = "many_refs.jl"
┌─────────┬────────────┬─────────┬───────────┬────────────┬──────────────┬───────────────────┬──────────┬────────────┐
│         │ total time │ gc time │ mark time │ sweep time │ max GC pause │ time to safepoint │ max heap │ percent gc │
│         │         ms │      ms │        ms │         ms │           ms │                us │       MB │          % │
├─────────┼────────────┼─────────┼───────────┼────────────┼──────────────┼───────────────────┼──────────┼────────────┤
│ minimum │        991 │     824 │       768 │         56 │          268 │                13 │      857 │         82 │
│  median │       1015 │     840 │       783 │         57 │          276 │                17 │      857 │         83 │
│ maximum │       1035 │     860 │       803 │         58 │          294 │                19 │      857 │         83 │
│   stdev │         17 │      14 │        13 │          1 │           10 │                 3 │        0 │          0 │
└─────────┴────────────┴─────────┴───────────┴────────────┴──────────────┴───────────────────┴──────────┴────────────┘
bench = "single_ref.jl"
┌─────────┬────────────┬─────────┬───────────┬────────────┬──────────────┬───────────────────┬──────────┬────────────┐
│         │ total time │ gc time │ mark time │ sweep time │ max GC pause │ time to safepoint │ max heap │ percent gc │
│         │         ms │      ms │        ms │         ms │           ms │                us │       MB │          % │
├─────────┼────────────┼─────────┼───────────┼────────────┼──────────────┼───────────────────┼──────────┼────────────┤
│ minimum │        460 │     319 │       311 │          8 │          111 │                17 │      857 │         68 │
│  median │        463 │     321 │       313 │          8 │          112 │                20 │      857 │         70 │
│ maximum │        478 │     329 │       321 │          8 │          116 │                28 │      857 │         70 │
│   stdev │          8 │       5 │         5 │          0 │            2 │                 4 │        0 │          1 │
└─────────┴────────────┴─────────┴───────────┴────────────┴──────────────┴───────────────────┴──────────┴────────────┘
category = "strings"
bench = "strings.jl"
┌─────────┬────────────┬─────────┬───────────┬────────────┬──────────────┬───────────────────┬──────────┬────────────┐
│         │ total time │ gc time │ mark time │ sweep time │ max GC pause │ time to safepoint │ max heap │ percent gc │
│         │         ms │      ms │        ms │         ms │           ms │                us │       MB │          % │
├─────────┼────────────┼─────────┼───────────┼────────────┼──────────────┼───────────────────┼──────────┼────────────┤
│ minimum │      14715 │    1713 │      1432 │        281 │           35 │               534 │      586 │         11 │
│  median │      15475 │    1779 │      1492 │        287 │           38 │               552 │      586 │         11 │
│ maximum │      16195 │    1857 │      1564 │        298 │           41 │               573 │      586 │         12 │
│   stdev │        721 │      58 │        54 │          7 │            3 │                15 │        0 │          0 │
└─────────┴────────────┴─────────┴───────────┴────────────┴──────────────┴───────────────────┴──────────┴────────────┘

@d-netto d-netto force-pushed the dcn-revert-gc-heuristics branch from 823b4f1 to 4ba6cca Compare January 3, 2024 10:46
kpamnany
kpamnany approved these changes Jan 4, 2024
View reviewed changes
Copy link
Collaborator

@kpamnany kpamnany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not such a big change, nice.

@d-netto d-netto merged commit acee054 into backports-release-1.10+RAI Jan 4, 2024
2 checks passed
@d-netto d-netto deleted the dcn-revert-gc-heuristics branch January 4, 2024 17:48
DelveCI pushed a commit that referenced this pull request Jan 6, 2024
@d-netto
revert GC heuristics back to 1.9 (#126)
9ed34ce
Drvi pushed a commit that referenced this pull request Jan 8, 2024
@d-netto @Drvi
revert GC heuristics back to 1.9 (#126)
36cc133
DelveCI pushed a commit that referenced this pull request Jan 13, 2024
@d-netto
revert GC heuristics back to 1.9 (#126)
f8a825a
DelveCI pushed a commit that referenced this pull request Jan 14, 2024
@d-netto
revert GC heuristics back to 1.9 (#126)
cffb61a
DelveCI pushed a commit that referenced this pull request Jan 15, 2024
@d-netto
revert GC heuristics back to 1.9 (#126)
d1f7fab
DelveCI pushed a commit that referenced this pull request Jan 17, 2024
@d-netto
revert GC heuristics back to 1.9 (#126)
03d55ca
DelveCI pushed a commit that referenced this pull request Jan 18, 2024
@d-netto
revert GC heuristics back to 1.9 (#126)
e07e5d5
DelveCI pushed a commit that referenced this pull request Jan 23, 2024
@d-netto
revert GC heuristics back to 1.9 (#126)
937e785
DelveCI pushed a commit that referenced this pull request Jan 24, 2024
@d-netto
revert GC heuristics back to 1.9 (#126)
feaf0ea
DelveCI pushed a commit that referenced this pull request Jan 25, 2024
@d-netto
revert GC heuristics back to 1.9 (#126)
2213a43
DelveCI pushed a commit that referenced this pull request Jan 27, 2024
@d-netto
revert GC heuristics back to 1.9 (#126)
cf7bae7
DelveCI pushed a commit that referenced this pull request Jan 30, 2024
@d-netto
revert GC heuristics back to 1.9 (#126)
776bd04
DelveCI pushed a commit that referenced this pull request Jan 31, 2024
@d-netto
revert GC heuristics back to 1.9 (#126)
325f177
DelveCI pushed a commit that referenced this pull request Feb 1, 2024
@d-netto
revert GC heuristics back to 1.9 (#126)
ac59a23
DelveCI pushed a commit that referenced this pull request Feb 6, 2024
@d-netto
revert GC heuristics back to 1.9 (#126)
095678d
DelveCI pushed a commit that referenced this pull request Feb 7, 2024
@d-netto
revert GC heuristics back to 1.9 (#126)
cbff275
DelveCI pushed a commit that referenced this pull request Feb 14, 2024
@d-netto
revert GC heuristics back to 1.9 (#126)
75a74e1
DelveCI pushed a commit that referenced this pull request Feb 21, 2024
@d-netto
revert GC heuristics back to 1.9 (#126)
235e750
DelveCI pushed a commit that referenced this pull request Feb 22, 2024
@d-netto
revert GC heuristics back to 1.9 (#126)
20fb04c
Drvi pushed a commit that referenced this pull request Feb 28, 2024
@d-netto @Drvi
revert GC heuristics back to 1.9 (#126)
21d71d5
DelveCI pushed a commit that referenced this pull request Mar 1, 2024
@d-netto
revert GC heuristics back to 1.9 (#126)
4a3d5bd
DelveCI pushed a commit that referenced this pull request Mar 13, 2024
@d-netto
revert GC heuristics back to 1.9 (#126)
a19a04f
Drvi pushed a commit that referenced this pull request Apr 3, 2024
@d-netto @Drvi
revert GC heuristics back to 1.9 (#126)
6a971a8
d-netto added a commit that referenced this pull request Apr 16, 2024
@d-netto
revert GC heuristics back to 1.9 (#126)
5c48576
DelveCI pushed a commit that referenced this pull request Apr 23, 2024
@d-netto
revert GC heuristics back to 1.9 (#126)
166b7f5
DelveCI pushed a commit that referenced this pull request Apr 24, 2024
@d-netto
revert GC heuristics back to 1.9 (#126)
a8b6d9d
DelveCI pushed a commit that referenced this pull request Apr 30, 2024
@d-netto
revert GC heuristics back to 1.9 (#126)
163ae46
DelveCI pushed a commit that referenced this pull request Apr 30, 2024
@d-netto
revert GC heuristics back to 1.9 (#126)
8114249
DelveCI pushed a commit that referenced this pull request May 2, 2024
@d-netto
revert GC heuristics back to 1.9 (#126)
0ad34af
DelveCI pushed a commit that referenced this pull request May 9, 2024
@d-netto
revert GC heuristics back to 1.9 (#126)
2aa8d10
DelveCI pushed a commit that referenced this pull request May 19, 2024
@d-netto
revert GC heuristics back to 1.9 (#126)
86428cb
DelveCI pushed a commit that referenced this pull request May 26, 2024
@d-netto
revert GC heuristics back to 1.9 (#126)
4c046ac
DelveCI pushed a commit that referenced this pull request May 28, 2024
@d-netto
revert GC heuristics back to 1.9 (#126)
05cbfec
DelveCI pushed a commit that referenced this pull request May 29, 2024
@d-netto
revert GC heuristics back to 1.9 (#126)
01ccad4
Drvi pushed a commit that referenced this pull request Jun 7, 2024
@d-netto @Drvi
revert GC heuristics back to 1.9 (#126)
c93a052
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpamnany kpamnany kpamnany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d-netto @kpamnany