Fix dyld lock not getting unlocked on invalid threads. (JuliaLang#49446)

RelationalAI · Oct 19, 2023 · 952f026 · 952f026
1 parent d854e6e
commit 952f026
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/src/signals-mach.c b/src/signals-mach.c
@@ -625,8 +625,7 @@ void *mach_profile_listener(void *arg)
             if (_dyld_atfork_prepare != NULL && _dyld_atfork_parent != NULL)
                 _dyld_atfork_prepare(); // briefly acquire the dlsym lock
             host_thread_state_t state;
-            if (!jl_thread_suspend_and_get_state2(i, &state))
-                continue;
+            int valid_thread = jl_thread_suspend_and_get_state2(i, &state);
             unw_context_t *uc = (unw_context_t*)&state;
             if (_dyld_atfork_prepare != NULL && _dyld_atfork_parent != NULL)
                 _dyld_atfork_parent(); // quickly release the dlsym lock