Try updating to object_store 0.8 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drvi
reviewed
Dec 13, 2023
nickrobinson251
commented
Dec 13, 2023
| @@ -291,7 +291,7 @@ pub extern "C" fn start() -> CResult { | |||
| let mut tries = 10; | |||
| loop { | |||
| match client.put(&p, slice.into()).await { | |||
| Ok(()) => { | |||
| Ok(_) => { | |||
There was a problem hiding this comment.
due to apache/arrow-rs#4944
jfunstonRAI
approved these changes
Dec 13, 2023
|
ideally we'd have more testing including benchmarks for changes like this in future opened a ticket about that: https://relationalai.atlassian.net/browse/RAI-19698 but for now i think it makes sense to be using the latest version of object_store so will risk the upgrade |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/apache/arrow-rs/blob/master/object_store/CHANGELOG.md#object_store_080-2023-11-02