Fix RuboCop errors

[mmx900]

Context

Fixed RuboCop errors that occurred after #689. These errors seem to be caused by upgrading rubocop-* gems. For example, rubocop-rspec, which was 2.13.2, added RSpec/Rails/InferredSpecType since 2.14.

Summary of Changes

• Fixed RuboCop errors
• Added config.infer_spec_type_from_file_location! to satisfy RSpec/Rails/InferredSpecType.

Checklist

• Tested Mobile Responsiveness
• Added Unit Tests
• CI Passes
• Deploys to Heroku on test Correctly (Maintainers will handle)
• Added Documentation (Service and Code when required)

Screenshots

Before

After

[DeeDeeG]

Nice, on this branch the Rubocop checks are passing, whereas in #691 the specs themselves were made passing.

The changes here look fairly trivial in terms of not changing the meaning/result of running the code, so, looks good to me!

(In more thoroughness/detail: Same number of "examples" being run in the specs, FWIW, just to confirm this doesn't change the meaning of the specs code. Non-spec code changes are 100% trivial in terms of meaningful changes, just satisfying the lints, so I am not worried about "uncaught" code changes in the app code itself. The lint messages themselves assure that the requested spec code changes are equivalent/were simply redundant or overly verbose before in most cases. So I am confident enough in the (very small) spec refactors as well.)

We may (we should) have green/passing CI again on develop branch with this merged.

Thank you!