-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework restroom-list view to be mobile responsive #483
Rework restroom-list view to be mobile responsive #483
Conversation
This looks really cool, thanks! I'm going to get it loaded on my machine and try it out. |
One little difference this makes (beside fixing #480) is that is can make the restroom icon rather small in some cases: I think it looks fine, and it definitely helps make good use of the screen width without anything overlapping like it used to. I'm in favor, overall. I love that this is fully responsive, and that the icon takes up just enough space now. And obviously the overlap issue is gone. Also, thank you for making the HTML more semantic by using |
For reasons totally unrelated to this PR, the Travis CI run failed. (It was a network error between Travis and the Gem server, apparently.) I'm re-starting the Travis CI build -- presumably it will pass this time. Edit: It passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will merge soon if there are no objections. 👍 |
Context
.restroom-list
module to be its own moduleSummary of Changes
.restroom-list
code (including@media
queries) to own file.restroom-list
class to be a mobile first by changing all class updates to build on mobile rather than break down from mobile._screen_sizes.scss
to utilize variable listed#list
to be aul
element to be more semantic.restroom-list
viewChecklist
Screenshots
Before
After