Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide changing table icon in minimal lists #473

Merged
merged 2 commits into from
Mar 15, 2018

Conversation

stardust66
Copy link
Contributor

@stardust66 stardust66 commented Mar 13, 2018

For example, in a list of nearby restrooms, both the gender neutral and accessibility icons are hidden while changing table icon still shows. Stumbled upon this when converting Coffeescript files.

Context

  • Add the changing table icon class to the list of things to be hidden in a .minimalRestroomList.

Checklist

  • Tested Mobile Responsiveness
  • Added Unit Tests
  • CI Passes
  • Deploys to Heroku on test Correctly (Maintainers will handle)
  • Added Documentation (Service and Code when required)

Screenshots

Before

screen shot 2018-03-13 at 6 16 04 pm

For example, in a list of nearby restrooms, both the gender neutral
and accessibility icons are hidden while changing table icon still
shows. Fixed by this commit.
@DeeDeeG
Copy link
Contributor

DeeDeeG commented Mar 14, 2018

Looks Good To Me after reading the CSS, but I haven't tested it out or anything just yet.

@DeeDeeG
Copy link
Contributor

DeeDeeG commented Mar 14, 2018

@stardust66
Copy link
Contributor Author

It shows up in trying to create a new restroom. When creating an entry, put in "Old West Church" in the street textbox, then hit preview. Drag the marker on the map a little bit and you'll see the icon in the list of nearby restrooms below. Screenshot was taken from production.

Copy link
Member

@mi-wood mi-wood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@mi-wood mi-wood merged commit b421808 into RefugeRestrooms:develop Mar 15, 2018
@tkwidmer tkwidmer mentioned this pull request May 18, 2018
@tkwidmer tkwidmer added this to the 1.12.0 milestone May 18, 2018
@stardust66 stardust66 deleted the hide-changing-table branch June 14, 2018 01:46
DeeDeeG pushed a commit to DeeDeeG/refugerestrooms that referenced this pull request Oct 15, 2018
…table

Hide changing table icon in minimal lists
DeeDeeG pushed a commit to DeeDeeG/refugerestrooms that referenced this pull request Nov 3, 2018
…table

Hide changing table icon in minimal lists
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants