-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filipino Translation #455
Filipino Translation #455
Conversation
Create about.fil.yml
Basically, the test system we use is broken, your translations are good. We can review your translations even if the tests fail. (The tests are automated and have a lot of moving parts. Sometimes one of those parts fails. This is one of those times.) I'm also copying this reply from another Pull Request (#454 (comment)), since I'm not sure if you saw it: Thank you for submitting these translations. The files you added look fine. Travis CI testing is showing errors in the pull requests you submitted, but I don't think the errors are caused by anything you did. The errors all look similar to this:
Our simulated web browser that tests our webpage is having problems. We will have to try and figure out why that's happening, but I don't think it should hold up merging these files. Eventually we hope to have the actual translations reviewed by another person or two who are fluent in Filipino. |
Pls. Review. Thanks :) |
Hi @vinzruzell could you try to translate the rest of the files? If only a few of them are translated, then the user is going to get a half translated application. |
Okay. I will finish translating the file. Thank you :)
…On Feb 17, 2018 9:23 AM, "Mikena Wood" ***@***.***> wrote:
Hi @vinzruzell <https://github.com/vinzruzell> could you try to translate
the rest of the files? If only a few of them are translated, then the user
is going to get a half translated application.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#455 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AhjYgLzuH_gSqYviY9HuTmuuPck-ex8_ks5tVioGgaJpZM4SGFUb>
.
|
I would like to ask also if your system checking is already fixed? So that
my translations will be reviewed :) thank you :)
…On Feb 17, 2018 9:40 AM, "Vincent Rosell" ***@***.***> wrote:
Okay. I will finish translating the file. Thank you :)
On Feb 17, 2018 9:23 AM, "Mikena Wood" ***@***.***> wrote:
> Hi @vinzruzell <https://github.com/vinzruzell> could you try to
> translate the rest of the files? If only a few of them are translated, then
> the user is going to get a half translated application.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#455 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AhjYgLzuH_gSqYviY9HuTmuuPck-ex8_ks5tVioGgaJpZM4SGFUb>
> .
>
|
We are looking into the problem, but in the mean-time, I'd recommend ignoring the test system. The test system does not test translations yet. There usually is no useful data in the results for translation PRs. We can ignore the test system and still review your translations manually. We can, and would, accept and merge your translations without the test system passing. We are a volunteer team, so this work is done in our spare time. Manually reviewing your Pull Request is easier than fixing the tests, and we are happy to manually review this Pull Request any time. We have to review manually anyway, even if the tests do pass, because the tests don't notice every issue. So the test system being broken is not a problem for this Pull Request. |
Thank you for that information :)
…On Feb 19, 2018 7:28 AM, "DeeDeeG" ***@***.***> wrote:
We are looking into the problem, but in the mean-time, I'd recommend
ignoring the test system.
The test system does not test translations yet. There usually is no useful
data in the results for translation PRs. We can ignore the test system and
still review your translations manually.
We can, and would, accept and merge your translations without the test
system passing.
We are a volunteer team, so this work is done in our spare time. Manually
reviewing your Pull Request is easier than fixing the tests, and we are
happy to manually review this Pull Request any time. We have to review
manually anyway, even if the tests *do* pass, because the tests don't
notice every issue. So the test system being broken is not a problem for
this Pull Request.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#455 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AhjYgGj8alkpUzR4lyiZLknot1eMJav7ks5tWLIsgaJpZM4SGFUb>
.
|
I am closing this Pull Request, since we have already accepted/merged |
Context
The proposed translation is from English language into Filipino language. For this translation I completed the whole file which is (about.en.yml) under config/locales.
Summary of Changes
I translated the project config/locales/en/about.en.yml (English) into config/locales/fil/about.fil.yml (Filipino Language)
'en' in the file has been changed to 'fil'
Checklist
Screenshots