-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make remaining pages translation-ready #421
Closed
Closed
Changes from 14 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
be9e684
config/locales: Delete unused "landing" file
DeeDeeG ce2cb91
splash page: Make translation-ready
DeeDeeG dd0a1f1
Contact page: Make translation-ready
DeeDeeG 1c6ef8f
Contact page: Fix h1 heading
DeeDeeG 5a37427
restroom search & entries: Make translation-ready
DeeDeeG 9abc8fb
navigation: Make translation-ready
DeeDeeG 5337341
footer: Make translation-ready
DeeDeeG 7c87ccf
search buttons: Make translation-ready
DeeDeeG 70c7c9c
contact: Simplify code for h1 header
DeeDeeG aede79b
footer: Reorganize the aria-label translations
DeeDeeG 7847997
text: Make translation-ready
DeeDeeG 8f8d7ef
contact: Change button label ['Submit' -> 'Send']
DeeDeeG ba3fefa
Merge branch 'new-translation-ready' into develop
DeeDeeG 2bc775f
contact submitted page: Make translation-ready
DeeDeeG ad63129
Merge branch 'develop' into new-translation-ready
mi-wood File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
.container | ||
%h1 Thank you for your message. | ||
%p We'll get back to you soon. | ||
%h1= t('contacts.submitted.thank-you-period') | ||
%p.centered-text= t('contacts.submitted.we-will-get-back-to-you') |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,20 +1,20 @@ | ||
%footer | ||
.footer | ||
%a.iconLink{:href => "https://github.com/RefugeRestrooms/refugerestrooms", :aria => { :label => "Refuge Restrooms on github"}} | ||
%a.iconLink{:href => "https://github.com/RefugeRestrooms/refugerestrooms", :aria => { :label => t('.aria-labels.github')}} | ||
%i.icon.fa.fa-github-square.fa-3x | ||
%a.iconLink{:href => "https://twitter.com/refugerestrooms", :aria => { :label => "Refuge Restrooms on twitter"}} | ||
%a.iconLink{:href => "https://twitter.com/refugerestrooms", :aria => { :label => t('.aria-labels.twitter')}} | ||
%i.icon.fa.fa-twitter-square.fa-3x | ||
%a.iconLink{:href => "https://www.facebook.com/refugerestrooms", :aria => { :label => "Refuge Restrooms on facebook"}} | ||
%a.iconLink{:href => "https://www.facebook.com/refugerestrooms", :aria => { :label => t('.aria-labels.facebook')}} | ||
%i.icon.fa.fa-facebook-square.fa-3x | ||
%a.iconLink{:href => "http://blog.refugerestrooms.org/", :aria => { :label => "Refuge Restrooms's blog on tumblr"}} | ||
%a.iconLink{:href => "http://blog.refugerestrooms.org/", :aria => { :label => t('.aria-labels.tumblr')}} | ||
%i.icon.fa.fa-tumblr-square.fa-3x | ||
%a.iconLink{:href => contact_path, :aria => { :label => "Email Refuge Restrooms"}} | ||
%a.iconLink{:href => contact_path, :aria => { :label => t('.aria-labels.email')}} | ||
%i.icon.fa.fa-envelope.fa-3x | ||
%br/ | ||
refuge restrooms is open source. | ||
%a{:href => "https://github.com/RefugeRestrooms/refugerestrooms"} code on github. | ||
= t('.refuge-restrooms-is-open-source') | ||
%a{:href => "https://github.com/RefugeRestrooms/refugerestrooms"} #{t('.code-on-github')} | ||
%br/ | ||
contribute to the project | ||
%a{:href => "https://patreon.com/refugerestrooms"} on patreon. | ||
= t('.contribute-to-the-project') | ||
%a{:href => "https://patreon.com/refugerestrooms"} #{t('.on-patreon')} | ||
%br/ | ||
= "\© copyleft #{Date.today.year} refuge restrooms.".html_safe | ||
= "\© #{t('.copyleft')} #{Date.today.year} #{t('.refuge-restrooms')}".html_safe |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
.text-padding | ||
%h1= t('pages.text_msg.title') | ||
%p= t('pages.text_msg.intro').html_safe | ||
%h2{:style => "text-align: center;"}= t('pages.text_msg.instructions') | ||
%p= t('.tip') | ||
%div{:style => "margin:30px auto;text-align:center;"} | ||
%h1= t('pages.text.title') | ||
%p.centered-text= t('pages.text.intro').html_safe | ||
%h2.centered-text= t('pages.text.instructions') | ||
%p.centered-text= t('.tip') | ||
%div.centered-text{:style => "margin:30px auto"} | ||
%img{:src => "/assets/text-msg-demo.png"}/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
en: | ||
contacts: | ||
new: | ||
request-edit-for-restroom: 'Request Edit for %{restroom_name} Restroom' | ||
contact-title: 'Contact' | ||
leave-this-field-blank: 'Leave this field blank!' | ||
submitted: | ||
thank-you-period: 'Thank you for your message.' | ||
thank-you-exclamation: 'Thank you for your message!' | ||
cannot-send: 'Cannot send message.' | ||
we-will-get-back-to-you: "We'll get back to you soon." |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
en: | ||
layouts: | ||
footer: | ||
aria-labels: | ||
github: 'Refuge Restrooms on GitHub' | ||
twitter: 'Refuge Restrooms on twitter' | ||
facebook: 'Refuge Restrooms on Facebook' | ||
tumblr: 'Refuge Restrooms blog on tumblr' | ||
email: 'Email Refuge Restrooms' | ||
refuge-restrooms-is-open-source: 'refuge restrooms is open source.' | ||
code-on-github: 'code on github.' | ||
contribute-to-the-project: 'contribute to the project' | ||
on-patreon: 'on patreon.' | ||
copyleft: 'copyleft' | ||
refuge-restrooms: 'refuge restrooms.' |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
en: | ||
layouts: | ||
navigation: | ||
toggle-navigation-button-label: 'Toggle navigation' | ||
submit-a-new-restroom-hyperlink-label: 'Submit a New Restroom' | ||
about-hyperlink-label: 'About' | ||
contact-hyperlink-label: 'Contact' | ||
|
||
resources-dropdown-button-label: 'Resources' | ||
download-unisex-restroom-signs-hyperlink-label: 'Download Unisex Restroom Signs' | ||
public-api-hyperlink-label: Public API |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
en: | ||
restrooms: | ||
index: | ||
map-view-button-label: 'Map View' | ||
|
||
show: | ||
thumbs-up-button-label: 'Thumbs Up' | ||
thumbs-down-button-label: 'Thumbs Down' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
en: | ||
layouts: | ||
search: | ||
search: 'Search' | ||
search-by-current-location: 'Search by Current Location' | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
en: | ||
pages: | ||
index: | ||
life-is-tough: 'Sometimes life is tough...' | ||
find-refuge: 'Find Refuge' | ||
add-restroom-button-label: 'Add A Restroom' |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a translation here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was a weird experience trying to translate this (buttons in
simple_form
are apparently from some other dimension compared to all other parts of forms) and try as I might, I couldn't figure out a way to translate this with the usualt('key.name.here')
format, inline inapp/views/contacts/new.html.haml
.per plataformatec/simple_form#i18n:
The translation ended up here: simple_form.en.yml, Line 27
This seemed like the logical place to put it.
I do notice that I accidentally changed the string from "Send message" -> "Submit message" so I can change that back if you like.
[Edit: Addressed in this commit:] 8f8d7ef