Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set locale based on Accept-Language header #420

Merged
merged 5 commits into from
Jan 13, 2018
Merged

Set locale based on Accept-Language header #420

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3c14d91
Correct indentation for config/application.rb
stardust66 Jan 10, 2018
bca00e5
Set website locale from Accept-Language header
stardust66 Jan 10, 2018
39060ab
Make sure the accept-language header is not nil
stardust66 Jan 11, 2018
d4232c0
Use http-accept-language gem to set locale
stardust66 Jan 12, 2018
b9e531d
Support different regions for the same language
stardust66 Jan 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion app/controllers/application_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,12 @@ def set_locale

private
def extract_locale_from_accept_language_header
request.env['HTTP_ACCEPT_LANGUAGE'].scan(/^[a-z]{2}/).first
accept_language = request.env['HTTP_ACCEPT_LANGUAGE']
if accept_language.nil?
"en"
else
request.env['HTTP_ACCEPT_LANGUAGE'].scan(/^[a-z]{2}/).first
end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sets the locale to be the top-preferred locale of the user's browser, whether we have that locale translated or not. Unfortunately, if the top-preferred locale is one we don't have, users see the translation key names in the page, rather than translated strings from an actual locale.

I think we should

  • Go through each of the user's preferred locales and use the first one we have.
  • Find a way to revert to en when the user's requested locales aren't ones we have.

Can use a gem to handle this, or do it directly in custom Ruby logic.

end

end