User edit proposals #414

mi-wood · 2018-01-07T21:31:55Z

I've got to step back for a bit and might need a second set of eyes, but here's what I have so far for restroom edit proposals.

The general plan is:

allow users to clock "propose restroom edit" on a restroom page
autofill the form with the current restroom data
submit new restroom with a new edit and an "edit_id" which is the original listing's id. the user then will be redirected to the original restroom page and be given a message that we're taking a look at the edit
allow an admin to view these edits and approve them. once approved, it will update the original listing and delete the edit

The default edit_id is 0, and restroom views will filter for this to avoid showing edits.

So far I've implemented 1,2 and the restroom filter.

I'm having an issue with the edit submission itself, where the form is redirecting to update instead of create. I think this has something to do with the coffeescript/js for submitting a restroom. Essentially, it will run the before_action for :find_restroom and fail. The id it fails on is the id of the edit where I would like the run the create method and redirect to the id of the original (also the edit_id on the copy).

DeeDeeG · 2018-01-08T20:24:12Z

[Edit: Reading your original comment above, I can see you are probably aware of everything I wrote in this comment. Sorry for not reading earlier.]

I'm going to start by trying to test the user-facing parts of this from an end-user perspective, since "front-end" is more of my strong area at the moment.

I did get an error when clicking the "submit" button after editing a restroom entry.

Here is a zipped .html file of the error page I see. (I got this by right clicking the error page and doing "Save As..."): Action Controller: Exception caught.html.zip

The error seems to be because the new page is submitted with a restroom entry "id" that isn't already in the database, which, taking a guess, I might expect would happen for adding a totally new restroom, vs submitting an edit.

Seems like the submit button functionality needs to be updated a bit.

By the way this would be a super great feature, users have definitely been asking for it, so I think it's very exciting to see some headway being made on this issue!

DeeDeeG · 2018-01-08T20:53:00Z

As for the Travis log:

This test: Scenario: Request edit from restroom # features/contact.feature:3
is failing, because this PR removes the "contact us about this post!" link in favor of a "Propose an edit to this listing." link. That test needs a quick update to reflect this PR.
This test: Scenario: View an edit # features/edit.feature:7
is undefined to some extent. (status is technically "undefined," not "failing")...

The step to visit the "edit page" for Winnipeg Restroom is undefined:

      Undefined step: "I visit the edit page for 'Winnepeg Restroom'" (Cucumber::Undefined)
      features/edit.feature:8:in `When I visit the edit page for 'Winnepeg Restroom''`

We need to update the definitions for the test so Cucumber knows how to visit Winnipeg Restroom's edit page.

This forces the form to submit to /restrooms with POST. Normally, simple_form_for would submit to /restrooms/:id with PATCH if the restroom already exists, which results in invoking the update method on restroom controller.

@Restroom

Add edit_id to permitted params and add it as a hidden field in the form, which allows it to be submitted. The edit_id set in the 'new' method only affects the value of the field in the form, and not the edit_id for the @Restroom in the create method, since they refer to different objects.

Redirect to the original restroom that was edited. params[:id] is nil because the params here are the ones submitted with the form, and there isn't an id field in the form.

DeeDeeG · 2018-01-16T04:19:35Z

#423 is @stardust66's go at part 3 outlined in the original post, if I understand correctly.

Implement correct editing behavior

mi-wood · 2018-01-18T03:26:38Z

I removed one of the old "contact" tests. Kept the second to test that past behavior remains the same.

I think the second one was just a typo for a capitol R in the step.

mi-wood · 2018-01-18T03:48:13Z

Looks like last time I might have just not finished the tests I was writing

DeeDeeG · 2018-01-18T03:55:25Z

I looked over the step definitions in the cucumber tests, and they seem fine on first glance. I suspect there is a technically relevant typo in there somewhere;

Somehow, an error message is being piped into the logic of the test.

  Scenario: View an edit                               # features/edit.feature:7
    When I visit the edit page for 'Winnepeg Restroom' # features/step_definitions/edit_steps.rb:10
    Then I should see the restroom address             # features/step_definitions/edit_steps.rb:15
      expected to find text "684 East hastings" in "ActiveRecord::RecordNotFound at /restrooms/new ============================================== > Couldn't find Restroom with 'id'= app/controllers/restrooms_controller.rb, line 84 ------------------------------------------------ ``` ruby 79 flash[:alert] = I18n.t('restroom.flash.unexpected') 80 end 81 end 82 83 def find_restroom > 84 @restroom = Restroom.find(params[:id]) 85 end 86 87 def permitted_params 88 params.require(:restroom).permit( 89 :edit_id, ``` App backtrace ------------- - app/controllers/restrooms_controller.rb:84:in `find_restroom' - app/controllers/restrooms_controller.rb:17:in `new' - features/step_definitions/edit_steps.rb:12:in `block in ' Full backtrace -------------- - activerecord (5.1.4) lib/active_record/core.rb:189:in `find' - app/controllers/restrooms_controller.rb:84:in `find_restroom' - app/controllers/restrooms_controller.rb:17:in `new' - actionpack (5.1.4) lib/action_controller/metal/basic_implicit_render.rb:4:in `send_action' - actionpack (5.1.4) lib/abstract_controller/base.rb:186:in `process_action' - actionpack (5.1.4) lib/action_controller/metal/rendering.rb:30:in `process_action'

see Line 1190 of the Travis test log.

(By the way, wading through errors describes most of the time I spent so far on #421, so I know what this sort of thing can be like.)

DeeDeeG · 2018-01-18T04:40:56Z

Unfortunately, same error as above (edit.feature:7), but also:

Scenario: Submit an edit                             # features/edit.feature:11
    When I submit an edit to 'Winnepeg Restroom'       # features/step_definitions/edit_steps.rb:19
      Unable to find visible field "restroom[name]" that is not disabled (Capybara::ElementNotFound)
      ./features/step_definitions/edit_steps.rb:22:in `/^I submit an edit to 'Winnepeg Restroom'$/'
      features/edit.feature:12:in `When I submit an edit to 'Winnepeg Restroom''
    Then I should see that the edit has been submitted # features/step_definitions/edit_steps.rb:26

mi-wood · 2018-03-07T00:29:23Z

Ok! I've actually got something here now :)

The new process is:

Add a column for edit_id and approved. Only listings with approved = true will show up, and the results will be grouped by edit_id using the most recent id
Allow users to propose edits that will add a new row with edit_id equal to the original listing id
The admin just has to set approved = true for approved edits in active admin.

@tkwidmer would appreciate your eyes on this one!

Anyone else can also pull down the branch and mess around with it. I added some tests and also tested that the geocoding updates for a change in address.

I still need to write a migration to add an edit_id = id for all the existing restrooms.

mi-wood · 2018-07-28T20:34:46Z

Closing in favor of: #487

mi-wood added 4 commits January 7, 2018 09:20

add rake description for vagrant

7fcabba

add edit_id migration

a0dcf8a

add edit_id with filter

469ee4b

add edit proposals

e16886c

stardust66 added 3 commits January 14, 2018 01:56

Force form route and method

be3530f

This forces the form to submit to /restrooms with POST. Normally, simple_form_for would submit to /restrooms/:id with PATCH if the restroom already exists, which results in invoking the update method on restroom controller.

Redirect to the right page after edit

4811249

Redirect to the original restroom that was edited. params[:id] is nil because the params here are the ones submitted with the form, and there isn't an id field in the form.

This was referenced Jan 14, 2018

Implement correct editing behavior #423

Merged

Add versions to all the migrations #426

Merged

mi-wood and others added 2 commits January 17, 2018 19:11

Merge pull request #423 from stardust66/user-edits

59df5d0

Implement correct editing behavior

fix cucumber tests

476338d

fill in missing test

b8a6f34

mi-wood added 9 commits March 5, 2018 13:10

resolve merge conflicts

2ec72bd

remove old contact spec

412ea8a

add edit process feature

4cc0f80

add approval functionality

2c44909

fix edit test

67c49aa

change currenet scope and fix api tests

ddd9dec

update current scope

9b1437a

commit before updated default factory

f8c8c1e

fix tests

38f545c

add permitted admin params

3b9e2bb

stardust66 mentioned this pull request Jun 13, 2018

User edit proposals - rebased on develop #487

Merged

4 tasks

mi-wood closed this Jul 28, 2018

mi-wood deleted the user-edits branch November 18, 2018 18:23

DeeDeeG mentioned this pull request Nov 18, 2018

User edits rebase #530

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

User edit proposals #414

User edit proposals #414

mi-wood commented Jan 7, 2018

DeeDeeG commented Jan 8, 2018 •

edited

Loading

DeeDeeG commented Jan 8, 2018 •

edited

Loading

DeeDeeG commented Jan 16, 2018 •

edited

Loading

mi-wood commented Jan 18, 2018

mi-wood commented Jan 18, 2018

DeeDeeG commented Jan 18, 2018 •

edited

Loading

DeeDeeG commented Jan 18, 2018

mi-wood commented Mar 7, 2018

mi-wood commented Jul 28, 2018

User edit proposals #414

User edit proposals #414

Conversation

mi-wood commented Jan 7, 2018

DeeDeeG commented Jan 8, 2018 • edited Loading

DeeDeeG commented Jan 8, 2018 • edited Loading

DeeDeeG commented Jan 16, 2018 • edited Loading

mi-wood commented Jan 18, 2018

mi-wood commented Jan 18, 2018

DeeDeeG commented Jan 18, 2018 • edited Loading

DeeDeeG commented Jan 18, 2018

mi-wood commented Mar 7, 2018

mi-wood commented Jul 28, 2018

DeeDeeG commented Jan 8, 2018 •

edited

Loading

DeeDeeG commented Jan 8, 2018 •

edited

Loading

DeeDeeG commented Jan 16, 2018 •

edited

Loading

DeeDeeG commented Jan 18, 2018 •

edited

Loading