Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize dotenv vars correctly in debian, simplify conf #193

Merged

Conversation

kiesia
Copy link
Contributor

@kiesia kiesia commented Jan 29, 2015

This commit fixes #170 on Debian at least.

@kiesia
Copy link
Contributor Author

kiesia commented Jan 30, 2015

@tkwidmer would be nice to get this checked on OSX an merged in, as the build is currently broken on (at least) debian.

@tkwidmer
Copy link
Contributor

wont this override the production env variable set in heroku?

@tkwidmer
Copy link
Contributor

Thats why we had test and development secret keys set. and didnt set just a general env variable.

@kiesia
Copy link
Contributor Author

kiesia commented Jan 30, 2015

@tkwidmer the dotenv gem is only bundled in the test and development environments, so it shouldn't be an issue on Heroku.

@tkwidmer
Copy link
Contributor

k, wanted to make sure

@tkwidmer tkwidmer closed this Jan 30, 2015
@tkwidmer tkwidmer reopened this Jan 30, 2015
tkwidmer added a commit that referenced this pull request Jan 30, 2015
Initialize dotenv vars correctly in debian, simplify conf
@tkwidmer tkwidmer merged commit 5694f83 into RefugeRestrooms:develop Jan 30, 2015
@kiesia kiesia deleted the hotfix/fix_devise_initialization branch January 31, 2015 01:55
@tkwidmer tkwidmer mentioned this pull request Jan 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Devise.secret_key was not set
2 participants