-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(number-field): support long press at spinner #983
Conversation
Deploying with Cloudflare Pages
|
Size Change: +298 B (0%) Total Size: 1.54 MB
ℹ️ View Unchanged
|
I could be mishearing it but did we find that long key press in input works but not consistent cross browsers? |
I wonder we can't do that. Long key press works because OS fires keydown event repeatedly. It's called Repeat rate on Windows. You can set up it on your OS keyboard setting. But mousedown/tap behavior fires only once times. |
packages/elements/src/number-field/__test__/number-field.step.test.js
Outdated
Show resolved
Hide resolved
packages/elements/src/number-field/__test__/number-field.step.test.js
Outdated
Show resolved
Hide resolved
packages/elements/src/number-field/__test__/number-field.step.test.js
Outdated
Show resolved
Hide resolved
packages/elements/src/number-field/__test__/number-field.step.test.js
Outdated
Show resolved
Hide resolved
packages/elements/src/number-field/__test__/number-field.step.test.js
Outdated
Show resolved
Hide resolved
packages/elements/src/number-field/__test__/number-field.step.test.js
Outdated
Show resolved
Hide resolved
…test.js Co-authored-by: Nantawat Poothong <[email protected]>
…test.js Co-authored-by: Nantawat Poothong <[email protected]>
…test.js Co-authored-by: Nantawat Poothong <[email protected]>
…test.js Co-authored-by: Nantawat Poothong <[email protected]>
packages/elements/src/number-field/__test__/number-field.step.test.js
Outdated
Show resolved
Hide resolved
…v/refinitiv-ui into feat/support-long-press
Co-authored-by: Nantawat Poothong <[email protected]>
Co-authored-by: Nantawat Poothong <[email protected]>
packages/elements/src/number-field/__test__/number-field.step.test.js
Outdated
Show resolved
Hide resolved
packages/elements/src/number-field/__test__/number-field.step.test.js
Outdated
Show resolved
Hide resolved
I think I disagree because this is normal behavior of hover css. Hover CSS class do when users point at the element, but does not necessarily activate it. |
…test.js Co-authored-by: Wasuwat Limsuparhat <[email protected]>
Co-authored-by: Wasuwat Limsuparhat <[email protected]>
Co-authored-by: Wasuwat Limsuparhat <[email protected]>
Co-authored-by: Wasuwat Limsuparhat <[email protected]>
Co-authored-by: Wasuwat Limsuparhat <[email protected]>
Co-authored-by: Wasuwat Limsuparhat <[email protected]>
Looks good kub. |
Co-authored-by: Wasuwat Limsuparhat <[email protected]>
Description
Support long press up/down spinner in Number Field
Fixes # (issue)
https://jira.refinitiv.com/browse/ELF-2265
Native Number field
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/number#try_it
Checklist