-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(interactive-chart): change chart property access modifier from private to public #864
Merged
bualoy-napat
merged 2 commits into
v7
from
feat/interactive-chart-public-chart-instance
Jul 28, 2023
Merged
fix(interactive-chart): change chart property access modifier from private to public #864
bualoy-napat
merged 2 commits into
v7
from
feat/interactive-chart-public-chart-instance
Jul 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with Cloudflare Pages
|
Size Change: +19 B (0%) Total Size: 1.54 MB
ℹ️ View Unchanged
|
Nantawat-Poothong
changed the title
feat(interactive-chart): change chart instance access modifier to public
fix(interactive-chart): change chart property access modifier from private to public
Jul 26, 2023
bualoy-napat
approved these changes
Jul 28, 2023
Please create another PR to sync this change to v6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It sound more sense to make docs api align with doc example and align with ef-chart
Solution:
Change chart instance access modifier to public
Ref:
#565
Fixes # (issue)
https://jira.refinitiv.com/browse/ELF-2214
Type of change