Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump test platform to Safari/iOS 16 - 18 #1221

Merged
merged 3 commits into from
Sep 30, 2024
Merged

chore: bump test platform to Safari/iOS 16 - 18 #1221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8868b08
chore: bump test platform to iOS 18
wattachai-lseg Sep 23, 2024
7584130
chore: bump test platform to macOS 15
wattachai-lseg Sep 24, 2024
cd41137
Merge branch 'v7' into chore/bump-test-platform-ios-18
wattachai-lseg Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions browsers.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ const BrowserStack = {
...DefaultMobileBrowsers,
'chrome_minus1',
'chrome_minus2',
'safari_minus2',
'firefox_minus1',
'firefox_minus2',
'android_minus1',
Expand All @@ -38,7 +37,7 @@ BrowserStack.availableBrowsers = [...BrowserStack.supportedBrowsers, ...BrowserS
// base platform config
const deviceConfig = { real_mobile: 'true' };
const windowsConfig = { os: 'Windows', os_version: '11' };
const macOSConfig = { os: 'OS X', os_version: 'Sonoma' };
const macOSConfig = { os: 'OS X', os_version: 'Sequoia' };

// BrowserStack Browsers Config
BrowserStack.config = {
Expand All @@ -52,16 +51,16 @@ BrowserStack.config = {
chrome_minus1: { ...windowsConfig, browser: 'chrome', browser_version: 'latest-1' },
firefox_minus1: { ...windowsConfig, browser: 'firefox', browser_version: 'latest-1' },
edge_minus1: { ...windowsConfig, browser: 'edge', browser_version: 'latest-1' },
safari_minus1: { ...macOSConfig, browser: 'safari', os_version: 'Ventura' },
safari_minus1: { ...macOSConfig, browser: 'safari', os_version: 'Sonoma' },

// minus2 versions
chrome_minus2: { ...windowsConfig, browser: 'chrome', browser_version: 'latest-2' },
firefox_minus2: { ...windowsConfig, browser: 'firefox', browser_version: 'latest-2' },
edge_minus2: { ...windowsConfig, browser: 'edge', browser_version: 'latest-2' },
safari_minus2: { ...macOSConfig, browser: 'safari', os_version: 'Monterey' },
safari_minus2: { ...macOSConfig, browser: 'safari', os_version: 'Ventura' },

// Mobile Devices
ios: { ...deviceConfig, browser: 'iphone', device: 'iPhone 15 Pro', os: 'ios', os_version: '17' },
ios: { ...deviceConfig, browser: 'iphone', device: 'iPhone 16 Pro', os: 'ios', os_version: '18' },
android: {
...deviceConfig,
browser: 'android',
Expand All @@ -71,7 +70,7 @@ BrowserStack.config = {
},

// Mobile Devices minus1 versions
ios_minus1: { ...deviceConfig, browser: 'iphone', device: 'iPhone 14 Pro', os: 'ios', os_version: '16' },
ios_minus1: { ...deviceConfig, browser: 'iphone', device: 'iPhone 15 Pro', os: 'ios', os_version: '17' },
android_minus1: {
...deviceConfig,
browser: 'android',
Expand All @@ -81,7 +80,7 @@ BrowserStack.config = {
},

// Mobile Devices minus2 versions
ios_minus2: { ...deviceConfig, browser: 'iphone', device: 'iPhone 13 Pro', os: 'ios', os_version: '15' },
ios_minus2: { ...deviceConfig, browser: 'iphone', device: 'iPhone 14 Pro', os: 'ios', os_version: '16' },
android_minus2: {
...deviceConfig,
browser: 'android',
Expand Down
2 changes: 1 addition & 1 deletion packages/elements/src/tree-select/__test__/tree-select.filter.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,7 +478,7 @@ describe('tree-select/Filter', function () {
await elementUpdated(el);

const noChildren = 0;
expect(el.children.length).to.equal(
expect(treeEl.children.length).to.equal(
noChildren,
`there should be ${noChildren} child(ren) with the provided custom filter & query of ${query}`
);
Expand Down