Skip to content
This repository has been archived by the owner on Sep 11, 2022. It is now read-only.

Page.getPage doesn't return Page #5

Open
Reewr opened this issue Apr 22, 2016 · 4 comments
Open

Page.getPage doesn't return Page #5

Reewr opened this issue Apr 22, 2016 · 4 comments
Labels
bug

Comments

@Reewr
Copy link
Owner

Reewr commented Apr 22, 2016

page.getPage does not currently return an instance of Page. This has been fixed in waiting commit, but due baudehlo/node-phantom-simple#131, I cannot yet push and publish this fix.
@Reewr Reewr added the bug label Apr 22, 2016
@Reewr Reewr added this to the 3.1.2 milestone Apr 22, 2016
@Reewr
Copy link
Owner Author

Reewr commented Jun 9, 2016

Pull request issued.

@Reewr
Copy link
Owner Author

Reewr commented Aug 8, 2016

I have now poked them and since they have taken way too long to even respond to my pull request, I'll go ahead and add other fixes.

Reewr added a commit that referenced this issue Aug 8, 2016
@Reewr
Comments out more tests that will fail due to #5
d9d2a8a
@Reewr
Copy link
Owner Author

Reewr commented Aug 8, 2016

Moves this to version 3.1.3, due to late responses.

@Reewr Reewr modified the milestones: 3.1.3, 3.1.2 Aug 8, 2016
@Reewr Reewr mentioned this issue Aug 12, 2016
Open
30 tasks
@Reewr Reewr removed this from the 3.1.3 milestone Jun 27, 2017
@Reewr
Copy link
Owner Author

Reewr commented Jun 27, 2017

There has been no new commits on node-phantom-simple for almost a year now. In addition, it seems that PhantomJS has been abandoned in favour of Chrome headless.

As such, I don't think this issue will ever be fixed, even if there's a pull request for it. I'll still keep this open for visibility, but do not expect it to be fixed anytime soon... sadly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Reewr