Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pickup command & refactoring #332

Merged
merged 12 commits into from
Apr 24, 2023
Merged

Pickup command & refactoring #332

merged 12 commits into from
Apr 24, 2023

Conversation

Deyan2306
Copy link
Contributor

@Deyan2306 Deyan2306 commented Apr 22, 2023 •
edited
Loading

Pull Request Etiquette

Changes

  • Internal code
  • Documentation
  • Other: _____

Closes Issue: NaN

Description

I made a new fun command -> PickUpLine and refactored some code (ternary operators) in the Waifu.java. Also added one sentence to the en translation

@Deyan2306
Copy link
Contributor Author

Just realized that i have put the en translation file in the /fun directory, instead of the languages one.
PS: This time i used direct upload, because i have a problem with the account from the terminal version of git. Sorry for the inconvenience

@Deyan2306 Deyan2306 requested a review from DxsSucuk April 22, 2023 11:54
@DxsSucuk
Copy link
Member

I will be reviewing the rest once I am home because its a pain job to do it via Github Mobile

@Deyan2306 Deyan2306 requested a review from DxsSucuk April 22, 2023 17:51
@Deyan2306
Copy link
Contributor Author

Fixed the hardcoding, I hope now it looks better. Also, switched from StringBuilder to a private String property.

@Deyan2306 Deyan2306 requested a review from DxsSucuk April 22, 2023 18:39
DxsSucuk
DxsSucuk requested changes Apr 22, 2023
View reviewed changes
languages/en-GB.yml Outdated
pickupline:
no_response: "I can't come up with a response right now."
response: ":speaking_head: %s"
responseNsfw: ":red_circle: **NSFW**"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You would need to change the responseNSFW to :red_circle: ||%s|| **NSFW**

@DxsSucuk
Copy link
Member

Other then the change request I just made everything looks great!
I will be testing the functionality later and if it works without any Issues it will merge into the main branch!

@Deyan2306
Copy link
Contributor Author

Nice! I hope everything is okay :D

@DxsSucuk DxsSucuk merged commit 0933d53 into Ree6-Applications:master Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DxsSucuk DxsSucuk DxsSucuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Deyan2306 @DxsSucuk