Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lint incorrectly reports boolean schemas for array items as invalid #532

Merged
merged 3 commits into from
Feb 3, 2022
Merged

fix: lint incorrectly reports boolean schemas for array items as invalid #532

merged 3 commits into from
Feb 3, 2022

Conversation

andriyl
Copy link
Contributor

@andriyl andriyl commented Jan 26, 2022 •
edited
Loading

What/Why/How?

Closes #457

Check yourself

  • Code is linted
  • Tested with redoc/reference-docs/workflows
  • All new/updated code is covered with tests

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@andriyl andriyl self-assigned this Jan 26, 2022
@andriyl andriyl marked this pull request as ready for review January 26, 2022 14:13
@andriyl andriyl requested a review from RomanHotsiy January 26, 2022 14:13
RomanHotsiy
RomanHotsiy requested changes Jan 31, 2022
View reviewed changes
Copy link
Member

@RomanHotsiy RomanHotsiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also add prefixItems keyword .

@andriyl andriyl requested a review from RomanHotsiy February 1, 2022 21:37
@andriyl andriyl merged commit 263dfa1 into master Feb 3, 2022
@andriyl andriyl deleted the fix/lint-boolean-schema-array branch February 3, 2022 09:40
@jeremyfiel jeremyfiel mentioned this pull request Aug 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomanHotsiy RomanHotsiy RomanHotsiy approved these changes

@tatomyr tatomyr tatomyr approved these changes

Assignees

@andriyl andriyl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lint incorrectly reports boolean schemas for array items as invalid
3 participants
@andriyl @RomanHotsiy @tatomyr