Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove x-expect from spot #1815

Merged
merged 3 commits into from
Nov 29, 2024
Merged

Conversation

DmitryAnansky
Copy link
Contributor

What/Why/How?

Remove x-expect from Spot.

Reference

Testing

Screenshots (optional)

Check yourself

  • Code changed? - Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests
  • New package installed? - Tested in different environments (browser/node)

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Copy link

changeset-bot bot commented Nov 29, 2024

🦋 Changeset detected

Latest commit: d88da77

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@redocly/openapi-core Patch
@redocly/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 29, 2024

Command Mean [s] Min [s] Max [s] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 1.016 ± 0.057 0.978 1.168 1.03 ± 0.06
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 0.984 ± 0.012 0.966 1.007 1.00

Copy link
Contributor

github-actions bot commented Nov 29, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 78.82% 5028/6379
🟡 Branches 67.19% 2050/3051
🟡 Functions 73.35% 831/1133
🟡 Lines 79.11% 4742/5994

Test suite run success

814 tests passing in 121 suites.

Report generated by 🧪jest coverage report action from d88da77

@DmitryAnansky DmitryAnansky marked this pull request as ready for review November 29, 2024 11:16
@DmitryAnansky DmitryAnansky requested review from a team as code owners November 29, 2024 11:16
@DmitryAnansky DmitryAnansky force-pushed the feat/remove-x-expect-from-spot branch from 8721490 to d88da77 Compare November 29, 2024 12:29
@DmitryAnansky DmitryAnansky merged commit 0616db6 into main Nov 29, 2024
40 checks passed
@DmitryAnansky DmitryAnansky deleted the feat/remove-x-expect-from-spot branch November 29, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants